Allow dynamic adding queues #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phstc
force-pushed
the
allow-dynamic-adding-queues-282
branch
from
49f5175
to
f90521c
Compare
h3poteto
reviewed
Mar 3, 2017
lib/shoryuken/environment_loader.rb
Outdated
| @@ -99,7 +99,7 @@ def prefix_active_job_queue_names | |||
| end | |||
|
|
|||
| def parse_queue(queue, weight = nil) | |||
| [weight.to_i, 1].max.times { Shoryuken.queues << queue } | |||
| Shoryuken.add_queue(queue, [weight.to_i, 1]) | |||
There was a problem hiding this comment.
You have not take the max of [weight.to_i, 1] but is it OK?
I think that add_queue takes weight which is defined numeric.
There was a problem hiding this comment.
@h3poteto nice! thanks for reviewing it. I meant [weight.to_i, 1].max.
This code needs a test rspec. Not sure how tests are passing, even the integration one.
phstc
commented
Mar 3, 2017
lib/shoryuken/environment_loader.rb
Outdated
| @@ -99,7 +99,7 @@ def prefix_active_job_queue_names | |||
| end | |||
|
|
|||
| def parse_queue(queue, weight = nil) | |||
| Shoryuken.add_queue(queue, [weight.to_i, 1]) | |||
| Shoryuken.add_queue(queue, [weight.to_i, 1].max) | |||
added 2 commits
March 5, 2017 22:01
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #282