Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logfile location in shoryuken.yml #190

Closed
VarunNatraaj opened this issue Apr 10, 2016 · 2 comments
Closed

Logfile location in shoryuken.yml #190

VarunNatraaj opened this issue Apr 10, 2016 · 2 comments

Comments

@VarunNatraaj
Copy link

@phstc I have provided log file path in shoryuken.yml file, but it is not picked at all. Could it be because initialize_logger comes before shoryuken options are merged with config_file_options? Or is that intentional? Also is there a list of attributes that can be provided and configured in shoryuken.yml?

@phstc
Copy link
Collaborator

phstc commented Apr 10, 2016

Hi @VarunNatraaj

Also is there a list of attributes that can be provided and configured in shoryuken.yml?

Unfortunately, it's spread in the README and Wiki entries. But it would be awesome to have wiki entry for that, if you research on that, would you mind to add a wiki entry with all options?

@phstc I have provided log file path in shoryuken.yml file, but it is not picked at all. Could it be because initialize_logger comes before shoryuken options are merged with config_file_options?

There's a PR #181 to fix that, could you test it? If it works, let's merged it. I didn't have a chance to test it yet.

@VarunNatraaj
Copy link
Author

@phstc I'd say moving this line to first should solve problems and have no impact as you're invoking logger only in load_rails. And use (options[:logger] || Shoryuken.options[:logger]) inside the method.

Also, wrt the wiki entry, I'll try 😄

@phstc phstc closed this as completed Apr 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants