Allow symbol as a queue name in shoryuken_options #177
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PullRequest change?
This PullRequest allows to use symbol for queue name in shoryuken_options.
e.g.
In this case,
:default
will be converted to'default'
, and work.Why is this need?
To use Amazon SQS, I was about to convert a sidekiq worker class to a shoryuken worker class.
But my worker was not be handled by shoryuken worker process though I enqueued to SQS with valid format message...
The converted shoryuken worker class is like the following:
And I noticed that sidekiq worker accepts symbol queue name, but shoryuken does not.
But as far as I read shoryuken's codes , I could not find any special reasons that Shoryken has to force the queue name to be Symbol.
So if there are not any special reasons, I think it is better to allow the Symbol for portability from Sidekiq.