Allow passing array of messages to send_messages #140
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't come up with a good reason why this would be the intended behavior, so I think it's a bug.
If a set of messages is passed to a queue like
queue.send_messages(batch)
, wherebatch
is:the messages are being corrupted before they actually get sent by
send_message_batch
on the client.When
sanitize_messages!
tries to reformat the value from anArray
to aHash
that is properly wrapped and ID'd, it doesn't take into account that the members of the array may be hashes. When hashes like in the example are used, the entire hash ends up getting serialized and shoved intomessage_body
.This change properly maintains the messages and adds an index, or behaves the old way if a string body is all that's getting passed in.