Skip to content

Commit

Permalink
I'm a completely stupid and removed the wrong version in rubygems
Browse files Browse the repository at this point in the history
  • Loading branch information
Pablo Cantero committed Jul 2, 2016
1 parent 1fb29bb commit b255bc3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/shoryuken/version.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module Shoryuken
VERSION = '2.0.10'
VERSION = '2.0.11'
end

8 comments on commit b255bc3

@phstc
Copy link
Collaborator

@phstc phstc commented on b255bc3 Jul 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mariokostelac OMG 😱 I'm a completely 🐴

I've wrongly yanked the version 2.0.10, and RubyGems does not let us to add it back:

Repushing of gem versions is not allowed.

I hope no one locked it in the Gemfile.

My completely bad.

@mariokostelac
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am pretty sure people are locking gem versions :S.

@mariokostelac
Copy link
Contributor

@mariokostelac mariokostelac commented on b255bc3 Jul 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phstc
Copy link
Collaborator

@phstc phstc commented on b255bc3 Jul 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got into that same article before pushing a new version 🐼

@jonahoffline
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not only 2.0.10, but all the gems down to version 2.0.5:
(from Rubygems)

2.0.10 - June 9, 2016 (63.5 KB) yanked
2.0.9 - June 8, 2016 (63.5 KB) yanked
2.0.8 - June 7, 2016 (63 KB) yanked
2.0.7 - June 6, 2016 (63 KB) yanked
2.0.6 - April 18, 2016 (62 KB) yanked
2.0.5 - April 17, 2016 (62 KB) yanked

@phstc
Copy link
Collaborator

@phstc phstc commented on b255bc3 Jul 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonahoffline some we needed to yank, they were completely bogus, we don't want people trying to deploy them. But 2.0.10, I shouldn't have yanked. I'm sorry for that, we will be extremely more careful with it in the future.

@jonahoffline
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phstc 👍 just thought you guys hadn't noticed. Awesome gem btw! 😄

@phstc
Copy link
Collaborator

@phstc phstc commented on b255bc3 Jul 10, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonahoffline thanks for checking it 🍻 ❤️

Please sign in to comment.