Special-case LateResolvableType in UnionType::isSuperTypeOf()

Author: ondrejmirtes

src/Type/UnionType.php

@@ -240,8 +240,7 @@ public function isSuperTypeOf(Type $otherType): IsSuperTypeOfResult
 			($otherType instanceof self && !$otherType instanceof TemplateUnionType)
 			|| ($otherType instanceof IterableType && !$otherType instanceof TemplateIterableType)
 			|| $otherType instanceof NeverType
-			|| $otherType instanceof ConditionalType
-			|| $otherType instanceof ConditionalTypeForParameter
+			|| ($otherType instanceof LateResolvableType && $otherType instanceof CompoundType)
 			|| $otherType instanceof IntegerRangeType
 		) {
 			return $otherType->isSubTypeOf($this);

tests/PHPStan/Analyser/NodeScopeResolverTest.php

@@ -103,6 +103,7 @@ private static function findTestFiles(): iterable
 
 		if (PHP_VERSION_ID >= 80000) {
 			yield __DIR__ . '/../Rules/Comparison/data/bug-4857.php';
+			yield __DIR__ . '/../Rules/PhpDoc/data/bug-13652.php';
 		}
 
 		yield __DIR__ . '/../Rules/Methods/data/bug-5089.php';

tests/PHPStan/Rules/PhpDoc/IncompatiblePhpDocTypeRuleTest.php

@@ -466,4 +466,19 @@ public function testBug13452(): void
 		$this->analyse([__DIR__ . '/data/bug-13452.php'], []);
 	}
 
+	#[RequiresPhp('>= 8.0')]
+	public function testBug13652(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-13652.php'], [
+			[
+				'PHPDoc tag @return with type array{a: string, b: bool, c: int, d: float}[TKey] is not subtype of native type bool|int|string.',
+				28,
+			],
+			[
+				'PHPDoc tag @param for parameter $value with type array{a: string, b: bool, c: int, d: float}[TKey] is not subtype of native type bool|int|string.',
+				48,
+			],
+		]);
+	}
+
 }

tests/PHPStan/Rules/PhpDoc/data/bug-13652.php

@@ -0,0 +1,57 @@
+<?php
+
+namespace Bug13652;
+
+use function PHPStan\Testing\assertType;
+
+/**
+ * @phpstan-type Bob array{a: string, b: bool, c: int, d: float}
+ */
+class Y {
+	public function __construct(/** @var Bob */ public array $bob) {}
+
+	/**
+	 * @template TKey of key-of<Bob>
+	 * @param TKey $key
+	 * @return Bob[TKey]
+	 */
+	public function x(string $key): string|bool|int|float
+	{
+		return $this->bob[$key];
+	}
+
+	/**
+	 * @template TKey of key-of<Bob>
+	 * @param TKey $key
+	 * @return Bob[TKey]
+	 */
+	public function x2(string $key): string|bool|int
+	{
+		return $this->bob[$key];
+	}
+
+	/**
+	 * @template TKey of key-of<Bob>
+	 * @param TKey $key
+	 * @param Bob[TKey] $value
+	 */
+	public function x3(string $key, string|bool|int|float $value): void
+	{
+
+	}
+
+	/**
+	 * @template TKey of key-of<Bob>
+	 * @param TKey $key
+	 * @param Bob[TKey] $value
+	 */
+	public function x4(string $key, string|bool|int $value): void
+	{
+
+	}
+}
+
+function (): void {
+	$y = new Y(['a' => 'y', 'b' => true, 'c' => 99, 'd' => 4.2]);
+	assertType('bool', $y->x('b'));
+};