Skip to content

Commit 34a0a0e

Browse files
committed
more variadic tests
1 parent 4cb9404 commit 34a0a0e

File tree

2 files changed

+41
-3
lines changed

2 files changed

+41
-3
lines changed

tests/Rules/PHPUnit/DataProviderDataRuleTest.php

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,13 +115,29 @@ public function testRule(): void
115115
277,
116116
],
117117
[
118-
'Parameter #1 $si of method DataProviderDataTest\TestInValidVariadic::testBar() expects int, string given.',
118+
'Parameter #1 $si of method DataProviderDataTest\TestInvalidVariadic::testBar() expects int, string given.',
119119
333,
120120
],
121121
[
122-
'Parameter #1 $s of method DataProviderDataTest\TestInValidVariadic::testFoo() expects string, int given.',
122+
'Parameter #1 $s of method DataProviderDataTest\TestInvalidVariadic::testFoo() expects string, int given.',
123123
333,
124124
],
125+
[
126+
'Parameter #1 $si of method DataProviderDataTest\TestInvalidVariadic2::testBar() expects int, string given.',
127+
355,
128+
],
129+
[
130+
'Parameter #2 ...$moreS of method DataProviderDataTest\TestInvalidVariadic2::testFoo() expects int, string given.',
131+
355,
132+
],
133+
[
134+
'Parameter #4 ...$moreS of method DataProviderDataTest\TestInvalidVariadic2::testFoo() expects int, string given.',
135+
355,
136+
],
137+
[
138+
'Parameter #1 $s of method DataProviderDataTest\TestInvalidVariadic2::testFoo() expects string, int given.',
139+
355,
140+
],
125141
]);
126142
}
127143

tests/Rules/PHPUnit/data/data-provider-data.php

Lines changed: 23 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -316,7 +316,7 @@ public function aProvider(): iterable
316316
}
317317
}
318318

319-
class TestInValidVariadic extends TestCase
319+
class TestInvalidVariadic extends TestCase
320320
{
321321
/** @dataProvider aProvider */
322322
public function testBar(int $si): void
@@ -336,3 +336,25 @@ public function aProvider(): iterable
336336
];
337337
}
338338
}
339+
340+
341+
class TestInvalidVariadic2 extends TestCase
342+
{
343+
/** @dataProvider aProvider */
344+
public function testBar(int $si): void
345+
{
346+
}
347+
348+
/** @dataProvider aProvider */
349+
public function testFoo(string $s, int ...$moreS): void
350+
{
351+
}
352+
353+
public function aProvider(): iterable
354+
{
355+
return [
356+
["hello", "world", 5, "bar"],
357+
[123]
358+
];
359+
}
360+
}

0 commit comments

Comments
 (0)