Restore PDOStatement::setFetchMode() signature

nikic · nikic · commit 4a5e17f9afed · 2019-12-06T07:18:11.000+01:00
I don't think this is worth the BC break, and getting variadic
signature changes compatible across PHP versions is somewhat tricky.
diff --git a/ext/pdo/pdo.stub.php b/ext/pdo/pdo.stub.php
@@ -129,5 +129,5 @@ public function rowCount() {}
     public function setAttribute(int $attribute, $value) {}
 
     /** @return bool */
-    public function setFetchMode(int $mode, ...$params) {}
+    public function setFetchMode(int $mode, $param1 = UNKNOWN, $param2 = UNKNOWN) {}
 }
diff --git a/ext/pdo/pdo_arginfo.h b/ext/pdo/pdo_arginfo.h
@@ -125,5 +125,6 @@ ZEND_END_ARG_INFO()
 
 ZEND_BEGIN_ARG_INFO_EX(arginfo_class_PDOStatement_setFetchMode, 0, 0, 1)
 	ZEND_ARG_TYPE_INFO(0, mode, IS_LONG, 0)
-	ZEND_ARG_VARIADIC_INFO(0, params)
+	ZEND_ARG_INFO(0, param1)
+	ZEND_ARG_INFO(0, param2)
 ZEND_END_ARG_INFO()

Original file line number	Diff line number	Diff line change
`@@ -129,5 +129,5 @@ public function rowCount() {}`
`129`	`129`	`public function setAttribute(int $attribute, $value) {}`
`130`	`130`
`131`	`131`	`/** @return bool */`
`132`		`- public function setFetchMode(int $mode, ...$params) {}`
	`132`	`+ public function setFetchMode(int $mode, $param1 = UNKNOWN, $param2 = UNKNOWN) {}`
`133`	`133`	`}`