Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warning due to Node 16 #43

Closed
Piedone opened this issue Oct 24, 2023 · 10 comments
Closed

Deprecation warning due to Node 16 #43

Piedone opened this issue Oct 24, 2023 · 10 comments

Comments

@Piedone
Copy link

Piedone commented Oct 24, 2023

Node 16 is now deprecated. Because of this, when using this action, you'll see warnings.

Please update the action to Node 20.

@Piedone
Copy link
Author

Piedone commented Jan 24, 2024

@IanMoroney could you please check this out?

@IanMoroney
Copy link
Contributor

Will do, thanks for raising 👍

@Piedone
Copy link
Author

Piedone commented Jan 24, 2024

Awesome, thank you!

@JohnYoungers
Copy link

I'm guessing this will work as-is by just updating the value to node20: https://github.com/phoenix-actions/test-reporting/blob/main/action.yml#L99

@fin-gordon-cko
Copy link

fin-gordon-cko commented Feb 7, 2024

This would require updating actions from @v2 to @v4
Worth noting in any update that upload-artifact@v4 is not fully backwards compatible with downoad-artifcact@v3 or below
Tried to create a branch for a quick fix but no permissions

@v1v v1v mentioned this issue Feb 21, 2024
@tonit
Copy link

tonit commented Feb 28, 2024

Would appreciate this one fixed. See existing PR. Waiting for it ;) (if you need more ppl upvoting this.

@tonit
Copy link

tonit commented Feb 28, 2024

One blocker (i might be wrong) is: downoad-artifcact@v4 is not available for GHEnterprise yet. :/

@Piedone
Copy link
Author

Piedone commented Mar 11, 2024

Any news on this by chance @IanMoroney?

@IanMoroney
Copy link
Contributor

Released now:
https://github.com/phoenix-actions/test-reporting/releases/tag/v13

Any issues, raise a new issue 👍

@Piedone
Copy link
Author

Piedone commented Mar 25, 2024

Great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants