-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
phlex:install
doesn’t add the Tailwind stylesheet to ApplicationLayout
#135
Comments
Good point! This would be great. |
Something I just noticed with the install_generator, it assumes that the Tailwind config lives under TAILWIND_CONFIGURATION_PATH = Rails.root.join("tailwind.config.js") ? I was wondering why Tailwind classes I was adding were not working when using my Phlex components and was able to track it down to that, my tailwind config wasn't updated when running |
@ibarreto I think that’s where the config used to be by default. |
The first part of this issue was fixed in #165. Open to pull requests adding the stylesheet link tag to |
@luiscobot did you figure this out in the end? If not - this depends on how you installed Tailwind, and ultimately, where your Once #204 lands in main, can you try and report any issues? |
Even though the generator patches
tailwind.config.js
to scan Phlex components, Tailwind classes won’t work until you manually addstylesheet_link_tag “tailwind”
toApplicationLayout
.IMO if Phlex already knows you’re using Tailwind, it’s reasonable to expect it to work out-of-the-box. I’d also love to submit a PR for this
The text was updated successfully, but these errors were encountered: