Unexpected order using find with comma separated selectors in v0.35.3

[danschultzer]

Upgrading from 0.35.2 to 0.35.3, find no longer conforms with the order of the document elements for comma separated selectors.

This is what 0.35.2 produces:

iex(1)> Floki.find("<div class=\"first\"></div><p class=\"second\"></p><div class=\"third\"></div>", "p,div")

[
  {"div", [{"class", "first"}], []},
  {"p", [{"class", "second"}], []},
  {"div", [{"class", "third"}], []}
]

This is what 0.35.3 produces:

iex(1)> Floki.find("<div class=\"first\"></div><p class=\"second\"></p><div class=\"third\"></div>", "p,div")

[
  {"p", [{"class", "second"}], []},
  {"div", [{"class", "first"}], []},
  {"div", [{"class", "third"}], []}
]

[philss]

Good call! I think the problem was introduced in #518 (d0be551 according to bisect).

@ypconstante would you mind to take a look? I wrote a small test case:

defmodule Floki.FindWithBug do
  use ExUnit.Case, async: true

  @tag only_parser: Floki.HTMLParser.Mochiweb
  test "correct order" do
    assert Floki.find(
             "<div class=\"first\"></div><p class=\"second\"></p><div class=\"third\"></div>",
             "p,div"
           ) ==
             [
               {"div", [{"class", "first"}], []},
               {"p", [{"class", "second"}], []},
               {"div", [{"class", "third"}], []}
             ]
  end
end

[ypconstante]

Yeah, the stack change is causing this.
I did some checks and there are more cases in which we don't return the nodes in the right order, unrelated with this change

iex> Floki.find(
  Floki.parse_fragment!("""
  <div id="1">
    <div id="2">
      <p id="3"></p>
    </div>
    <p id="4"></p>
  </div>
  """),
  "div p"
)

[{"p", [{"id", "4"}], []}, {"p", [{"id", "3"}], []}]