Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a way to format percentage intervals #35

Closed
philsf opened this issue Jul 1, 2018 · 2 comments · Fixed by #51
Closed

Find a way to format percentage intervals #35

philsf opened this issue Jul 1, 2018 · 2 comments · Fixed by #51

Comments

@philsf
Copy link
Owner

philsf commented Jul 1, 2018

The current state of affairs prevents the use of format.pct in format.interval, because format.float returns "NA" for both ends of the interval.

Possible solutions

  • include an argument in format.interval to consider the interval as proportions
  • include a check in format.float to see if the last char is "%"
@philsf philsf added the bug label Jul 1, 2018
@philsf philsf added this to the v0.6.1 milestone Jul 1, 2018
@philsf philsf modified the milestones: v0.6.1, v0.6.2 Sep 28, 2018
@philsf
Copy link
Owner Author

philsf commented Oct 5, 2018

With the solution to #40 , now format.interval should work by default on percentages, unless the pct.symbol is manually defined in the argument setting.

Consider if this is sill a valid issue.

@philsf philsf added the question label Oct 5, 2018
@philsf philsf modified the milestones: v0.6.2, v0.6.3 Oct 16, 2018
@philsf
Copy link
Owner Author

philsf commented Oct 22, 2018

#49 means that it is more important to solve this issue here, than to change every point where the function has been used before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant