-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing taxranks that appear in NCBI Taxonomy Database #5
base: master
Are you sure you want to change the base?
Conversation
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
@cthoyt any chance you can add the OWL conversion? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks so much @cthoyt. I agree there should be a contributors template. I'll make that an issue so it can be tracked.
@balhoff are you handling new release etc? |
Closes #4
This PR adds the ranks that appear in the NCBI Taxonomy Database to TAXRANK. Here's a table that shows the impact of each of these terms, where the count is how many distinct NCBI Taxa have this rank. I then ran
make
andmake prepare_release
after.Note: I also did a bit of housekeeping in this PR too to add the license and contributor list.