Fix of the sign convention of rotation matrices #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… HiggsRotationMatrixEnsuredConvention vector
…matrices where only massless Goldstones should be (which can happen for a faulty parameter point with a negative mass)
cborschensky
requested review from
phbasler,
lisabiermann,
JonasMueller1991 and
vollous
as code owners
|
Can you make this PR to the "develop" branch? |
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #169. The mismatch between conventions of rotation matrices is resolved by enforcing the parametrisation of arXiv:2007.02985, Eqs. (5) ff.
We implement a new function$-\frac{\pi}{2}$ and $+\frac{\pi}{2}$ . This new rotation matrix, saved in the vector
AdjustRotationMatrix()which calculates the rotation matrix in the parametrisation of the given paper and ensures that the rotation angles are withinHiggsRotationMatrixEnsuredConvention, is then used for the calculation insideTripleHiggsCouplings(). The convention for the rotation matrices and angles as calculated by BSMPT now also agrees with the one used in theScannerScode.Additionally, the indices for the mass eigenstates in the rotation matrix are now computed just once for all implemented models inside the respective
AdjustRotationMatrix()function (previously, the indices were computed separately in thewrite()andTripleHiggsCouplings()functions).General structure of the changes and implementation for the R2HDM by @lisabiermann.