Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Convert sha1 references to hash #15844

Closed
niden opened this issue Dec 28, 2021 · 1 comment
Closed

[BUG]: Convert sha1 references to hash #15844

niden opened this issue Dec 28, 2021 · 1 comment
Assignees
@niden
Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: low Low

Comments

@niden
Copy link
Member

niden commented Dec 28, 2021

Although not a huge issue, in the remote chance that there are collisions created by sha1 we need to change all references to it to hash("sha256", $data) just in case.
@niden niden added bug A bug report status: unverified Unverified labels Dec 28, 2021
@niden niden self-assigned this Dec 28, 2021
@niden niden added 5.0 The issues we want to solve in the 5.0 release status: low Low and removed status: unverified Unverified labels Dec 28, 2021
@niden niden mentioned this issue Dec 28, 2021
Closed
5 tasks
@niden niden linked a pull request Dec 28, 2021 that will close this issue
T15844 sha1 #15845
Closed
5 tasks
@niden niden mentioned this issue Dec 28, 2021
Merged
@niden
Copy link
Member Author

niden commented Dec 28, 2021

Resolved in #15845

@niden niden closed this as completed Dec 28, 2021
@niden niden moved this to Implemented in Phalcon v5 Aug 25, 2022
@niden niden added this to Phalcon v5 Aug 25, 2022
@niden niden moved this from Implemented to Released in Phalcon v5 Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niden niden

Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: low Low
Projects
Phalcon v5
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

T15844 sha1
1 participant
@niden