Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFR]: Add ConfigInterface #15106

Closed
BeMySlaveDarlin opened this issue Jul 12, 2020 · 1 comment · Fixed by #15114
Closed

[NFR]: Add ConfigInterface #15106

BeMySlaveDarlin opened this issue Jul 12, 2020 · 1 comment · Fixed by #15114
Labels
new feature request Planned Feature or New Feature Request

Comments

@BeMySlaveDarlin
Copy link
Contributor

Is your feature request related to a problem? Please describe.
It smells as hack typehinting Phalcon/Config in other services when extending it by custom class => feels as LSP violation.

Describe the solution you'd like

  • Add Phalcon/ConfigInterface filled with most methods from Phalcon/Config itself and from Phalcon/Collection.
  • Implement it in Phalcon/Config.
  • Replace all internal typehints to interface.

Describe alternatives you've considered
It also can be Phalcon/CollectionInterface, but less usable.

Thanks.
@BeMySlaveDarlin BeMySlaveDarlin added the new feature request Planned Feature or New Feature Request label Jul 12, 2020
@BeMySlaveDarlin BeMySlaveDarlin changed the title [NFR]: [NFR]: Add ConfigInterface Jul 12, 2020
@BeMySlaveDarlin BeMySlaveDarlin mentioned this issue Jul 20, 2020
Merged
5 tasks
@niden niden added the 4.1.0 label Jul 26, 2020
@niden niden linked a pull request Jul 26, 2020 that will close this issue
Collection and Config Interfaces #15114
Merged
5 tasks
@niden
Copy link
Member

niden commented Jul 26, 2020

Resolved in #15114

@niden niden closed this as completed Jul 26, 2020
@niden niden moved this to Released in Phalcon v5 Aug 25, 2022
@niden niden added this to Phalcon v5 Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new feature request Planned Feature or New Feature Request
Projects
Phalcon v5
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Collection and Config Interfaces BeMySlaveDarlin/cphalcon
2 participants
@niden @BeMySlaveDarlin