Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFR]: Update Phalcon Documentation Before New Phalcon Releases #14498

Closed
ghost opened this issue Oct 29, 2019 · 8 comments
Closed

[NFR]: Update Phalcon Documentation Before New Phalcon Releases #14498

ghost opened this issue Oct 29, 2019 · 8 comments
Labels
new feature request Planned Feature or New Feature Request

Comments

@ghost
Copy link

ghost commented Oct 29, 2019

Please do not remove or change anything that breaks phalcon from older version without properly commenting code, providing example code or at least updating phalcon documentation. Phalcon documentation should be updated before new version of phalcon is released. This is why there is too many people confused on GitHub submitting duplicated bugs.

@ghost ghost added the new feature request Planned Feature or New Feature Request label Oct 29, 2019
@niden
Copy link
Member

niden commented Oct 29, 2019

Do you have any examples of that happening right now?

@ghost ghost changed the title [NFR]: Update Phalcon Documentation Before New Release [NFR]: Update Phalcon Documentation Before New Phalcon Releases Oct 29, 2019
@ghost
Copy link
Author

ghost commented Oct 29, 2019

@niden Yes, I do actually. The newest $di->setShared('view') #14496

@niden
Copy link
Member

niden commented Oct 29, 2019

You are jumping the gun here without waiting for us to react and honestly it is not fair for everyone. Some information:

phalcon-orphanage/docs#2322

This tracks our current update list of the v4 documentation. As you can see there are a bit short of 20 documents to review/revise. Di is one of them so the documentation for that has not been updated yet. You can check the status of the document being red here:

https://docs.phalcon.io/4.0/en/di

For documents that we have worked on and revised, they look like this:

https://docs.phalcon.io/4.0/en/cache

and also there is the upgrade document here:

https://docs.phalcon.io/4.0/en/upgrade#cache

(the above link shows directly what one needs to do for the Cache component in particular)

For the issue you outlined #14496 , it was a duplicate of #14491 and there is work underway for it in this PR: #14497

I applaud your enthusiasm and thank you for your diligence. Just check the issues and PRs just in case something is already being addressed or is duplicate.

@ghost
Copy link
Author

ghost commented Oct 29, 2019

@niden okay thank you!

@niden
Copy link
Member

niden commented Oct 29, 2019

That is my point exactly. It happened after we released the code, our tests did not pick that up. A user reported it and we are working to fix it. Nothing else to it really. It is just like any other bug that has been found. The fact that all these are being reported now is great.

Honestly I don't know why you thought that this was an intended/design change - it was not in the upgrade doc. But either way. We are on it.

Thank you again for keeping a close eye on things :)

@ghost
Copy link
Author

ghost commented Oct 29, 2019

Why do you use RC versions instead of beta? As I understand from wikipedia;

Release candidate - A release candidate (RC), also known as "going silver", is a beta version with potential to be a final product, which is ready to release unless significant bugs emerge.

RC version should NOT have any removals or changes that break version from previous version.

Source: https://en.wikipedia.org/wiki/Software_release_life_cycle#Release_candidate

@niden
Copy link
Member

niden commented Oct 29, 2019

As with any software, bugs can and will appear. alpha, beta, RC or even stable versions suffer from those. This was not a change that was intended. Just a change that brought unintended consequences. We just need to add a few more tests to our suite so that the particular bug is caught if it appears again.

That was it really.

@ghost
Copy link
Author

ghost commented Oct 29, 2019

@niden Thank you for explaining. Keep up the great work you guys do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature request Planned Feature or New Feature Request
Projects
None yet
Development

No branches or pull requests

2 participants