-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Phalcon\Mvc\Url #13742
Comments
This comment was marked as abuse.
This comment was marked as abuse.
I agree. I also suggest renaming For example:
|
If they are empty then can be abandoned also, because Injectable can be used directly in PHP. And why User\Module exists? we have... |
@ekmst The Honestly those classes do nothing. They just offer a more intuitive way to make a class DI aware which one can do easily by extending As for the Url. Yes I agree. It would be best if we move it out of the Mvc namespace and I would love to see if I can introduce also the |
This has been resolved |
I agree with @ekmst for
But for Url it would be better to do something like;
|
I propose to rename
Phalcon\Mvc\Url
toPhalcon\Url
. Since theUrl
is used not only in web applications but also in console (and micro) applications too. I think it will be semantic more correct.Phalcon\Mvc\Url
toPhalcon\Url
Phalcon\Mvc\UrlInterface
toPhalcon\UrlInterface
Phalcon\Mvc\Url\Exception
toPhalcon\Url\Exception
The text was updated successfully, but these errors were encountered: