Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.0.0]Change catch Exception to Throwable, drop PHP 5 support #12288

Closed
Jurigag opened this issue Oct 4, 2016 · 0 comments
Closed

[4.0.0]Change catch Exception to Throwable, drop PHP 5 support #12288

Jurigag opened this issue Oct 4, 2016 · 0 comments
Labels
breaks bc Functionality that breaks Backwards Compatibility discussion Request for comments and discussion
Milestone
4.0.0

Comments

@Jurigag
Copy link
Contributor

Jurigag commented Oct 4, 2016 •
edited
Loading

  • Change all catch \Exception to catch \Throwable in Phalcon\Dispatcher, Phalcon\Micro, Phalcon\Pdo\Postgresql
  • This means drop php 5 support
@sergeyklay sergeyklay added this to the 4.0.0 milestone Oct 4, 2016
@Jurigag Jurigag mentioned this issue Oct 5, 2016
Closed
@sergeyklay sergeyklay added the discussion Request for comments and discussion label Oct 6, 2016
@sergeyklay sergeyklay added the breaks bc Functionality that breaks Backwards Compatibility label Jul 17, 2017
@sergeyklay sergeyklay mentioned this issue Aug 21, 2017
Merged
@niden niden added the 4.0 label Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaks bc Functionality that breaks Backwards Compatibility discussion Request for comments and discussion
Projects
None yet
Milestone
4.0.0
Development

No branches or pull requests
3 participants
@niden @sergeyklay @Jurigag