Skip to content

Commit 0ae0af7

Browse files
committed
topotests: add unified configuration
Replace the various per-daemon config files with a unique frr.conf configuration file. Signed-off-by: Philippe Guibert <[email protected]>
1 parent 36391df commit 0ae0af7

File tree

8 files changed

+66
-68
lines changed

8 files changed

+66
-68
lines changed

tests/topotests/bgp_bmp/test_bgp_bmp_1.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ def setup_module(mod):
7878
"tcpdump -nni r1-eth0 -s 0 -w {} &".format(pcap_file), stdout=None
7979
)
8080

81-
for rname, router in tgen.routers().items():
81+
for _, (rname, router) in enumerate(tgen.routers().items(), 1):
8282
logger.info("Loading router %s" % rname)
8383
router.load_frr_config(
8484
os.path.join(CWD, "{}/frr.conf".format(rname)),

tests/topotests/bgp_evpn_rt5/r1/bgpd.conf renamed to tests/topotests/bgp_evpn_rt5/r1/frr.conf

+23
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,27 @@
1+
log stdout
2+
3+
hostname r1
4+
password zebra
5+
6+
! debug zebra vxlan
7+
! debug zebra kernel
8+
! debug zebra dplane
9+
! debug zebra rib
110
! debug bgp neighbor-events
211
! debug bgp updates
312
! debug bgp zebra
13+
log stdout
14+
vrf r1-vrf-101
15+
vni 101
16+
exit-vrf
17+
!
18+
interface r1-eth0
19+
ip address 192.168.100.21/24
20+
!
21+
interface loop101 vrf r1-vrf-101
22+
ip address 192.168.102.21/32
23+
ipv6 address fd00::1/128
24+
!
425
router bgp 65000
526
bgp router-id 192.168.100.21
627
bgp log-neighbor-changes
@@ -42,3 +63,5 @@ exit
4263
route-map rmap_r1 permit 1
4364
match evpn vni 101
4465
exit
66+
67+

tests/topotests/bgp_evpn_rt5/r1/zebra.conf

-23
This file was deleted.

tests/topotests/bgp_evpn_rt5/r2/bgpd.conf renamed to tests/topotests/bgp_evpn_rt5/r2/frr.conf

+19
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,24 @@
1+
log stdout
2+
3+
hostname r2
4+
password zebra
5+
6+
! debug zebra vxlan
17
! debug bgp neighbor-events
28
! debug bgp updates
39
! debug bgp zebra
10+
11+
vrf r2-vrf-101
12+
vni 101
13+
exit-vrf
14+
!
15+
interface loop101 vrf r2-vrf-101
16+
ip address 192.168.101.41/32
17+
ipv6 address fd00::2/128
18+
!
19+
interface r2-eth0
20+
ip address 192.168.100.41/24
21+
!
422
router bgp 65000
523
bgp router-id 192.168.100.41
624
bgp log-neighbor-changes
@@ -49,3 +67,4 @@ exit
4967
route-map rmap6 deny 2
5068
match ipv6 address acl6_2
5169
exit
70+

tests/topotests/bgp_evpn_rt5/r2/zebra.conf

-19
This file was deleted.

tests/topotests/bgp_evpn_rt5/r3/bgpd.conf renamed to tests/topotests/bgp_evpn_rt5/r3/frr.conf

+13
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,17 @@
11
! debug bgp neighbor-events
22
! debug bgp updates
33
! debug bgp zebra
4+
vrf r3-vrf-102
5+
vni 102
6+
exit-vrf
7+
!
8+
interface r3-eth0
9+
ip address 192.168.100.61/24
10+
!
11+
interface loop102 vrf r3-vrf-102
12+
ip address 192.168.102.61/32
13+
ipv6 address fd00:6::1/128
14+
!
415
router bgp 65500
516
bgp router-id 192.168.100.61
617
bgp log-neighbor-changes
@@ -31,3 +42,5 @@ router bgp 65000 vrf r3-vrf-102
3142
advertise ipv6 unicast
3243
exit-address-family
3344
!
45+
46+

tests/topotests/bgp_evpn_rt5/r3/zebra.conf

-13
This file was deleted.

tests/topotests/bgp_evpn_rt5/test_bgp_evpn.py

+10-12
Original file line numberDiff line numberDiff line change
@@ -159,21 +159,19 @@ def setup_module(mod):
159159
tgen.net["r1"].cmd_raises("ip -n r1-vrf-101 link set bridge-101 up")
160160
tgen.net["r1"].cmd_raises("ip -n r1-vrf-101 link set vxlan-101 up")
161161

162-
for rname, router in router_list.items():
162+
for rname, router in tgen.routers().items():
163+
logger.info("Loading router %s" % rname)
163164
if rname == "r1":
164-
router.load_config(TopoRouter.RD_MGMTD, None, "--vrfwnetns")
165-
router.load_config(
166-
TopoRouter.RD_ZEBRA,
167-
os.path.join(CWD, "{}/zebra.conf".format(rname)),
168-
"--vrfwnetns",
165+
router.load_frr_config(
166+
os.path.join(CWD, "{}/frr.conf".format(rname)),
167+
[
168+
(TopoRouter.RD_MGMTD, "--vrfwnetns"),
169+
(TopoRouter.RD_ZEBRA, "--vrfwnetns"),
170+
(TopoRouter.RD_BGP, None),
171+
],
169172
)
170173
else:
171-
router.load_config(
172-
TopoRouter.RD_ZEBRA, os.path.join(CWD, "{}/zebra.conf".format(rname))
173-
)
174-
router.load_config(
175-
TopoRouter.RD_BGP, os.path.join(CWD, "{}/bgpd.conf".format(rname))
176-
)
174+
router.load_frr_config(os.path.join(CWD, "{}/frr.conf".format(rname)))
177175

178176
# Initialize all routers.
179177
tgen.start_router()

0 commit comments

Comments
 (0)