Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve hashing.{dir,zip}_hash efficiency. #1850

Open
jsirois opened this issue Jul 13, 2022 · 0 comments
Open

Improve hashing.{dir,zip}_hash efficiency. #1850

jsirois opened this issue Jul 13, 2022 · 0 comments
Labels
tech-debt Issue that addresses technical debt.

Comments

@jsirois
Copy link
Member

jsirois commented Jul 13, 2022

As pointed out by @benjyw in #1845 (review) these hashing functions could reduce memory overhead for zips / directory trees with huge listings. They could also stand to share some code so they produce a consistent hash for a zipped and unzipped dir of the same contents. They could also use a dedicated set of tests to prove this consistency.
@jsirois jsirois added the tech-debt Issue that addresses technical debt. label Jul 13, 2022
@jsirois jsirois mentioned this issue Jul 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech-debt Issue that addresses technical debt.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jsirois