Skip to content

feat: implement issue #2161 — dev-lead: switch on the maintainer no-change path safely (unrecorded-reply gap, live proof of stamping, cutoff wiring) — follow-up to #2079 / PR #2084 #2239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
don-petry merged 4 commits into from
Oct 11, 2026
Merged

feat: implement issue #2161 — dev-lead: switch on the maintainer no-change path safely (unrecorded-reply gap, live proof of stamping, cutoff wiring) — follow-up to #2079 / PR #2084 #2239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4f6070a
feat: implement issue #2161 — dev-lead: switch on the maintainer no-c…
Oct 11, 2026
93ae21c
fix(reviews): treat only a leading @ in a field value as a file refer…
don-petry Oct 11, 2026
8ec9174
fix(reviews): flag only POST calls that can create a reply and accept…
don-petry Oct 11, 2026
124d811
fix(reviews): reject a no-change verdict when a bot finding was edite…
don-petry Oct 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/dev-lead-reusable.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,13 @@ jobs:
# variable — NOT a workflow_call input — so no channel-pin sequencing is
# needed. Empty => the guard auto-discovers (npm/make/pytest/bats).
DEV_LEAD_TEST_CMD: ${{ vars.DEV_LEAD_TEST_CMD }}
# The instant from which a maintainer's "no change needed" reply may resolve a
# bot review thread (nochange_epoch_cutoff in dev-lead-fix-reviews.sh, #2079 /
# #2161). Mapped from an Actions variable, NOT a workflow_call input, so no
# channel-pin sequencing is needed. Unset or unparseable => the no-change path
# stays disabled. Set it only after the stamping release is on every consumer's
# dev-lead channel (see #2161).
DEV_LEAD_NOCHANGE_EPOCH: ${{ vars.DEV_LEAD_NOCHANGE_EPOCH || '' }}
# Empty by default so dev-lead-intent.sh derives the trusted set from the
# reviewer-source registry (scripts/lib/reviewer-sources.tsv), the single
# source of truth — no hardcoded list to drift from the gate/scorecard
Expand Down
Loading
Loading