-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When using lost-move, have it retain the gutter if specified by a previous lost-column #195
Comments
Looking at line 30 of the That's not really an answer, I suppose. |
Maybe the gutter could be passed on to |
We can probably do something where we look through that current block of definitions for Thanks for pointing this out. |
@sidonaldson Here's a codepen with this "fixed". http://codepen.io/peterramsing/pen/dGNXmK You can specify the gutter within the I'm working on getting the |
@corysimmons Was there any reason that lost-move.js doesn't use "newBlock()"? |
Closing to migrate discussion to the PR #219 |
@corysimmons I think I answered my own question about |
👍 tbh, I'm not sure. I might have just overlooked it. If it works with newBlock, newBlock should probably be added so the property is uniform with the rest of them. |
I'm noticing a few things that are inconsistent, but not breaking. Any refactor will have to wait. I'd love to get some of these bugs/issues deployed before doing any refactor work. Maybe when I have another long weekend I'll spend sometime doing that and maybe getting some linting in place. |
Sounds good. 👍 |
With the work that I did with the |
Closing for #350 |
Hi Cory, I think I've found a little bug with the
lost-move
where it seems to default to the global gutter value.In the test case I have two columns (1/3 and 2/3) and I want to swap their positions and without any gutter.
The problem is that
lost-move
ignores the gutter override and you still get a gap and the offsets are out.I can get around it by setting
@lost gutter 0;
but that's not ideal.Demo: http://codepen.io/sidonaldson/pen/rxVvpm/
What do you think?
The text was updated successfully, but these errors were encountered: