Skip to content
This repository has been archived by the owner on Jun 2, 2020. It is now read-only.

Question: Why is Cargo.lock .dockerignored by default #487

Open
cbrevik opened this issue Dec 21, 2019 · 2 comments
Open

Question: Why is Cargo.lock .dockerignored by default #487

cbrevik opened this issue Dec 21, 2019 · 2 comments
Milestone

Comments

@cbrevik
Copy link
Contributor

cbrevik commented Dec 21, 2019

Hi! Thanks for the wonderful crate.

Just a quick question, why is Cargo.lock ignored in the copy operation over to the Docker-image by default?

As seen here:

I can just remove it of course, but wondering if there is any benefit to keeping it ignored that I have not seen.

@peterhuene peterhuene added this to the 0.12.0 milestone Dec 29, 2019
@peterhuene
Copy link
Owner

I don't remember why it was excluded and I can't think of a reason why it should be off the top of my head (the "publishing" support hasn't gotten much love in a long time).

If it isn't causing problems then the exclusion should be removed.

@cbrevik
Copy link
Contributor Author

cbrevik commented Dec 29, 2019

Okay! The reason I asked was because a CI build of mine broke for an app using azure-functions-rs, because another dependency I use had a breaking change in a patch version.

Sort of perfect storm of someone not properly following semver, coupled with the Cargo.lock not being copied into the Docker-image being built. It was a bit of a head-scratcher trying to figure out.

By the way, I noticed while doing the example code for #488 that the root Cargo.lock was being altered when building the example-code. Maybe that has something to do with it?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants