Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error_handler option as Proc to Dalli::Store #907

Closed
johnnyshields opened this issue Mar 20, 2022 · 2 comments
Closed

Add error_handler option as Proc to Dalli::Store #907

johnnyshields opened this issue Mar 20, 2022 · 2 comments

Comments

@johnnyshields
Copy link

Currently Dalli::Store supports a raise_errors (true/false) config.

I'd like more fine grained error handling like Rail's Redis Store supports. Would propose to add error_handler option as a proc, which is what Redis does.

My main reason for this is related to: rack/rack-attack#577

@petergoldstein
Copy link
Owner

@johnnyshields Dalli::Store is no longer supported. It was deprecated in the 2.7.x versions and removed with 3.0.x.

You can find the MemCacheStore class here - https://github.com/rails/rails/blob/main/activesupport/lib/active_support/cache/mem_cache_store.rb

@johnnyshields
Copy link
Author

Thanks, will close issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants