Skip to content
This repository has been archived by the owner on Jun 1, 2023. It is now read-only.

modernize core modules #97

Closed
rurban opened this issue Dec 24, 2015 · 2 comments
Closed

modernize core modules #97

rurban opened this issue Dec 24, 2015 · 2 comments
Assignees

Comments

@rurban
Copy link
Member

rurban commented Dec 24, 2015

use proper sigs where ever possible in our internal libraries.

1st, this catches arity and wrong argument types at compile-time.
2nd, this calling convention is faster than via @_
3rd, enhances the signatures #7 test coverage.

See branch featurex/gh7-sig+libs https://github.com/perl11/cperl/commits/featurex/gh7-sig+libs

@rurban rurban self-assigned this Dec 24, 2015
@rurban rurban mentioned this issue Dec 24, 2015
@rurban
Copy link
Member Author

rurban commented Jan 11, 2016

As of f946e8bf05db6d0470dc2d040d4a53f28870c749 we are down to 4 test failures,
caused by tailcalls to signatures via goto.

  • ../cpan/Test-Simple/t/auto.t (goto sig via AUTOLOAD)
  • ../cpan/Test-Simple/t/capture.t (goto sig via AUTOLOAD)
  • ../cpan/Test-Simple/t/run_test.t (goto sig via AUTOLOAD)
  • ../lib/perl5db.t (nextstate op between entersub and signature, fixed with signatures with -d: no nextstate before signature #109)

but I cannot just disable goto/AUTOLOAD when jumping to a signature.

@rurban
Copy link
Member Author

rurban commented Jan 24, 2017

Done for a long time already. Published with v5.24.0c

@rurban rurban closed this as completed Jan 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant