Skip to content

Commit 947a612

Browse files
authored
go.mod: bump to go1.20 (#24)
Update github actions Fix staticheck lint.
1 parent f88d4d2 commit 947a612

File tree

3 files changed

+15
-20
lines changed

3 files changed

+15
-20
lines changed

.github/workflows/test.yml

+10-18
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
# benchmarks. At the end do a quick check to ensure the tests to not leave
2020
# files in the tree.
2121
test:
22-
name: "test: go${{matrix.gover}}.x/${{matrix.os}}"
22+
name: "test: ${{matrix.os}}"
2323
runs-on: "${{matrix.os}}"
2424
continue-on-error: true
2525
defaults:
@@ -29,8 +29,6 @@ jobs:
2929
fail-fast: false
3030
matrix:
3131
os: [ubuntu-latest, macos-latest, windows-latest]
32-
# Do not forget to bump every 6 months!
33-
gover: ["1.19"]
3432
env:
3533
PYTHONDONTWRITEBYTECODE: x
3634
steps:
@@ -40,10 +38,9 @@ jobs:
4038
- uses: actions/checkout@v3
4139
with:
4240
fetch-depth: 2
43-
- uses: actions/setup-go@v3
41+
- uses: actions/setup-go@v4
4442
with:
45-
go-version: "~${{matrix.gover}}.0"
46-
cache: true
43+
go-version-file: go.mod
4744
- name: 'go install necessary tools'
4845
if: always()
4946
run: |
@@ -53,6 +50,7 @@ jobs:
5350
run: go test -timeout=120s -covermode=count -coverprofile coverage.txt -bench=. -benchtime=1x ./...
5451
# Don't send code coverage if anything failed to reduce spam.
5552
- uses: codecov/codecov-action@v2
53+
timeout-minutes: 1
5654
- name: 'Cleanup'
5755
if: always()
5856
run: rm coverage.txt
@@ -87,7 +85,7 @@ jobs:
8785
# to cut on runtime, at the cost of latency. I dislike waiting for results
8886
# so I prefer to run them in parallel.
8987
lint:
90-
name: "lint: go${{matrix.gover}}.x/${{matrix.os}}"
88+
name: "lint: ${{matrix.os}}"
9189
runs-on: "${{matrix.os}}"
9290
continue-on-error: true
9391
defaults:
@@ -100,19 +98,16 @@ jobs:
10098
# OS-specific code benefits from explicitly linting on macOS and
10199
# Windows.
102100
os: [ubuntu-latest, macos-latest, windows-latest]
103-
# Do not forget to bump every 6 months!
104-
gover: ["1.19"]
105101
env:
106102
PYTHONDONTWRITEBYTECODE: x
107103
steps:
108104
- name: Turn off git core.autocrlf
109105
if: matrix.os == 'windows-latest'
110106
run: git config --global core.autocrlf false
111107
- uses: actions/checkout@v3
112-
- uses: actions/setup-go@v3
108+
- uses: actions/setup-go@v4
113109
with:
114-
go-version: "~${{matrix.gover}}.0"
115-
cache: true
110+
go-version-file: go.mod
116111
- name: "Debug"
117112
run: |
118113
echo HOME = $HOME
@@ -296,23 +291,20 @@ jobs:
296291

297292

298293
codeql:
299-
name: "codeql: go${{matrix.gover}}.x/${{matrix.os}}"
294+
name: "codeql: ${{matrix.os}}"
300295
runs-on: "${{matrix.os}}"
301296
continue-on-error: true
302297
strategy:
303298
fail-fast: false
304299
matrix:
305300
os: [ubuntu-latest]
306-
# Do not forget to bump every 6 months!
307-
gover: ["1.19"]
308301
permissions:
309302
security-events: write
310303
steps:
311304
- uses: actions/checkout@v3
312-
- uses: actions/setup-go@v3
305+
- uses: actions/setup-go@v4
313306
with:
314-
go-version: "~${{matrix.gover}}.0"
315-
cache: true
307+
go-version-file: go.mod
316308
- name: Initialize CodeQL
317309
uses: github/codeql-action/init@v2
318310
with:

analog/analog_test.go

+4-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,10 @@ func TestINVALID(t *testing.T) {
3535
if INVALID.Halt() == nil {
3636
t.Fatal("Halt")
3737
}
38-
INVALID.Range()
38+
sample := Sample{}
39+
if s1, s2 := INVALID.Range(); s1 != sample || s2 != sample {
40+
t.Fatal("Range")
41+
}
3942
if _, err := INVALID.Read(); err == nil {
4043
t.Fatal("Read")
4144
}

go.mod

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
module periph.io/x/conn/v3
66

7-
go 1.17
7+
go 1.20
88

99
// Warning: do not add any external dependencies here unless absolutely necessary.
1010
// This package should primarily depend on the standard library.

0 commit comments

Comments
 (0)