Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

looper inspect is broken #462

Closed
nsheff opened this issue Feb 16, 2024 · 3 comments
Closed

looper inspect is broken #462

nsheff opened this issue Feb 16, 2024 · 3 comments
Assignees
Milestone

Comments

@nsheff
Copy link
Contributor

nsheff commented Feb 16, 2024

looper inspect
Looper version: 1.7.0
Command: inspect
Using looper config (.looper.yaml).
Config file does not have version key. Defaulting to 2.1.0
Config file does not have version key. Defaulting to 2.1.0
Traceback (most recent call last):
  File "/home/nsheff/.local/bin/looper", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/home/nsheff/.local/lib/python3.11/site-packages/looper/cli_looper.py", line 760, in main
    prj.pipestat_configured_project if args.project else prj.pipestat_configured
                                       ^^^^^^^^^^^^
AttributeError: 'Namespace' object has no attribute 'project'
@nsheff nsheff added the bug label Feb 16, 2024
@nsheff nsheff added this to the v1.8.0 milestone Feb 16, 2024
@donaldcampbelljr
Copy link
Contributor

Looking at inspect I see that there is a warning that this feature has moved to Eido and will be removed from Looper:

looper/looper/cli_looper.py

Lines 789 to 796 in 8d029bf

if args.command == "inspect":
inspect_project(p, args.sample_names, args.attr_limit)
from warnings import warn
warn(
"The inspect feature has moved to eido and will be removed in the future release of looper. "
"Use `eido inspect` from now on.",
)

It does appear that Eido has inspect functionality added in 2021 and modified as recently as June 2023:
https://github.com/pepkit/eido/blob/a2aa751d2a4db49b12bd90129cee97100291c1cd/eido/cli.py#L166-L173

Question:

Should we go ahead and remove the inspect command from Looper?

@nsheff
Copy link
Contributor Author

nsheff commented Mar 12, 2024

No, those are different things to me.

eido should inspect the PEP.

looper inspect should inspect the looper config

I guess that comment comes from before looper config was a thing.

looper inspect could include the results of the eido inspect, for the pep aspect of the config.

@donaldcampbelljr
Copy link
Contributor

Should be solved with the above PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants