Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the :param relations to generated dvc bash scripts and dvc-in arguments are confusing in docs #84

Open
antonkulaga opened this issue Apr 27, 2020 · 1 comment
Assignees

Comments

@antonkulaga
Copy link

antonkulaga commented Apr 27, 2020

I have multiple string parameters in notebooks. In the beginning I thought that all the params I declare as :param in docstrings should be automatically passed to dvc bash script as dvc -p because it looked intuitive. However, it is not the way how generated DVC bash work: I do not see acceptance of the :param arguments which I declared in DVC bash scripts which are generated. I think the documentation should clarify how/if DVC bash scripts interact with :param arguments, otherwise it leads to a lot of confusion and wasted time

@antonkulaga antonkulaga changed the title the _dvc bash scripts are very confusing in terms of giving parameters the dvc_in docs are confusing Apr 27, 2020
@antonkulaga antonkulaga changed the title the dvc_in docs are confusing the :param and :dvc_in relations in docs are confusing Apr 27, 2020
@antonkulaga antonkulaga changed the title the :param and :dvc_in relations in docs are confusing the :param relations to generated dvc bash scripts and dvc-in arguments are confusing in docs Apr 27, 2020
@SdgJlbl
Copy link
Collaborator

SdgJlbl commented Jun 30, 2020

Hello,
Thank you for your issue and sorry for the late reply - I was not notified by Github for some reasons...

Thank you for your feedback, I'll try to clarify the documentation with respect to that point.
In the mean time:

  • :param in the docstring are used by the first part of MLV-tools, which converts Jupyter Notebooks to Python scripts. In your .py file, these parameters are then accessible, and you can modify them from the command line too. In particular, they can be used as "parameters" for DVC.
  • in order for your parameters/arguments to be recognized by DVC, you need to specify what role they will have in DVC: dependencies dvc-in, output dvc-out, not versioned by DVC dvc-extra.

We plan to add support for DVC parameters and DVC metrics very soon.

By curiosity, could you tell me which part of the documentation did you use the most? Did you rely on the project README, or did you also have a look at the tutorials (https://github.com/peopledoc/mlvtools-tutorial)?
Thank you, and sorry again for missing your issues.

@SdgJlbl SdgJlbl self-assigned this Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants