Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tower-abci: add support for gRPC #31

Open
erwanor opened this issue Jul 24, 2023 · 0 comments
Open

tower-abci: add support for gRPC #31

erwanor opened this issue Jul 24, 2023 · 0 comments
Assignees

Comments

@erwanor
Copy link
Member

erwanor commented Jul 24, 2023

What's the downside to adding gRPC support to tower-abci?

We could have a second Server implementation that translates Tonic-generated types into domain types and invokes the inner tower::Services, and wouldn't need to jump through the hoops the TSP server does to translate into requests/responses.

We wouldn't have to wait on any upstream, and it would give us optionality to migrate to grpc communication with no significant changes to pd.

Originally posted by @hdevalence in penumbra-zone/penumbra#2771 (comment)

This is currently blocked on merging https://github.com/informalsystems/tendermint-rs/pull/1338/files into tendermint-rs, #30 , and upgrading to [email protected] when it is released.

@erwanor erwanor moved this to Testnet 58: Mimas in Testnets Jul 24, 2023
@erwanor erwanor self-assigned this Jul 24, 2023
@erwanor erwanor moved this from Testnet 58: Mimas to Testnet 59: Enceladus in Testnets Aug 4, 2023
@erwanor erwanor moved this from Testnet 59: Enceladus to Next (Steal from here) in Testnets Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Next
Development

No branches or pull requests

1 participant