Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/penny help errors in private channels #376

Open
JnBrymn opened this issue Nov 3, 2020 · 0 comments
Open

/penny help errors in private channels #376

JnBrymn opened this issue Nov 3, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@JnBrymn
Copy link
Collaborator

JnBrymn commented Nov 3, 2020

steps to repro

Expected: we would see the message appear in the private channel OR AT LEAST no sentry error

problem

Sentry indicates that the error is comming in chat_postEphemeral_with_fallback when we attempt to post an ephemeral message I can help you make a new Penny Chat to a direct channel (these are always prefixed with D). The "fallback" is to post the help message in the #Penny channel

solution

It would be nice if we could post a message in a private channel, but perhaps it makes sense that we can't. We need to check if Slack commands have any special allowances for things like this. Otherwise we need to just need to send to the Penny channel first without attempting to send to a private channel. WARNING: We have introduced a feature in matching where the bot creates a private channel and joins it. I think in this case the channel is reachable by the bot. Test this theory!

Also consider just not sending the Sentry exception in these cases. (They're currently still being sent - https://sentry.io/organizations/penny-university/issues/2005111335/?project=5284085&query=is%3Aunresolved)

@JnBrymn JnBrymn added the bug Something isn't working label Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant