From 855181b09f237a9db140401900e655e4e879c45b Mon Sep 17 00:00:00 2001
From: Weihan Li <weihanli@outlook.com>
Date: Fri, 21 Jun 2024 08:51:51 +0800
Subject: [PATCH 1/2] feat: init central package version management

---
 Directory.Build.props                         |  4 --
 Directory.Packages.props                      | 45 +++++++++++++++++++
 .../Xunit.DependencyInjection.Analyzer.csproj |  4 +-
 ...pendencyInjection.AspNetCoreTesting.csproj |  2 +-
 ...nit.DependencyInjection.Demystifier.csproj |  2 +-
 .../Xunit.DependencyInjection.Logging.csproj  |  2 +-
 ...t.DependencyInjection.SkippableFact.csproj |  4 +-
 .../Xunit.DependencyInjection.StaFact.csproj  |  4 +-
 .../Xunit.DependencyInjection.xRetry.csproj   |  4 +-
 .../Xunit.DependencyInjection.csproj          |  6 +--
 test/TestPackages.targets                     |  6 +--
 ...t.DependencyInjection.Analyzer.Test.csproj | 10 ++---
 ...nit.DependencyInjection.Test.FSharp.fsproj |  8 ++--
 .../Xunit.DependencyInjection.Test.csproj     |  6 +--
 14 files changed, 75 insertions(+), 32 deletions(-)
 create mode 100644 Directory.Packages.props

diff --git a/Directory.Build.props b/Directory.Build.props
index 95b7eef..98d01de 100644
--- a/Directory.Build.props
+++ b/Directory.Build.props
@@ -25,10 +25,6 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.*" PrivateAssets="All" Condition="'$(TargetFrameworkIdentifier)' == '.NETFramework'" />
-    <PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.*" PrivateAssets="All" />
-    <PackageReference Include="PolySharp" Version="1.*" PrivateAssets="All" />
-
     <Reference Include="System.Net.Http" Condition="'$(TargetFrameworkIdentifier)' == '.NETFramework'" />
   </ItemGroup>
 
diff --git a/Directory.Packages.props b/Directory.Packages.props
new file mode 100644
index 0000000..e58a277
--- /dev/null
+++ b/Directory.Packages.props
@@ -0,0 +1,45 @@
+<Project>
+  <PropertyGroup>
+    <ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
+    <!-- need to enable floating version support explicitly for now -->
+    <CentralPackageFloatingVersionsEnabled>true</CentralPackageFloatingVersionsEnabled>
+  </PropertyGroup>
+  <ItemGroup>
+    <PackageVersion Include="xRetry" Version="[1.9.0, 2.0.0)" />
+    <PackageVersion Include="xunit.core" Version="[2.4.2, 3.0.0)" />
+  
+    <PackageVersion Include="Autofac.Extensions.DependencyInjection" Version="9.*" />
+    <PackageVersion Include="FluentAssertions" Version="6.*" />
+    <PackageVersion Include="FSharp.Core" Version="8.*" />
+    
+    <PackageVersion Include="Microsoft.CodeAnalysis" Version="4.*" />
+
+    <!-- https://github.com/dotnet/roslyn-sdk/blob/main/src/Microsoft.CodeAnalysis.Testing/README.md -->
+    <PackageVersion Include="Microsoft.CodeAnalysis.CSharp.Analyzer.Testing" Version="1.*" />
+    <PackageVersion Include="Microsoft.CodeAnalysis.CSharp.CodeFix.Testing" Version="1.*" />
+    <PackageVersion Include="Microsoft.CodeAnalysis.CSharp.CodeRefactoring.Testing" Version="1.*" />
+  
+    <PackageVersion Include="Ben.Demystifier" Version="0.*" />
+    <PackageVersion Include="coverlet.collector" Version="6.0.2" />
+    <PackageVersion Include="MartinCostello.Logging.XUnit" Version="0.*" />
+    <PackageVersion Include="Microsoft.AspNetCore.Mvc.Testing" Version="$(_TargetFrameworkVersionWithoutV)" />
+    <PackageVersion Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.0.1" />
+    <PackageVersion Include="Microsoft.Extensions.Hosting" Version="8.0.0" />
+    <PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.*" />
+    <PackageVersion Include="xunit" Version="2.*" />
+    <PackageVersion Include="xunit.extensibility.execution" Version="[2.4.2, 3.0.0)" />
+    <PackageVersion Include="xunit.runner.visualstudio" Version="2.*" />
+    <PackageVersion Include="Xunit.DependencyInjection" Version="9.0.0" />
+    <PackageVersion Include="Xunit.SkippableFact" Version="1.4.13" />
+    <PackageVersion Include="Xunit.StaFact" Version="1.1.11" />
+  </ItemGroup>
+  <ItemGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETFramework'">
+    <PackageVersion Include="System.Threading.Tasks.Extensions" Version="4.*" />
+    <PackageVersion Include="System.ValueTuple" Version="4.*" />
+    <GlobalPackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.*"/>
+  </ItemGroup>
+  <ItemGroup>
+    <GlobalPackageReference Include="Microsoft.SourceLink.GitHub" Version="8.*" />
+    <GlobalPackageReference Include="PolySharp" Version="1.*" />
+  </ItemGroup>
+</Project>
diff --git a/src/Xunit.DependencyInjection.Analyzer/Xunit.DependencyInjection.Analyzer.csproj b/src/Xunit.DependencyInjection.Analyzer/Xunit.DependencyInjection.Analyzer.csproj
index aa532e5..1f21d0b 100644
--- a/src/Xunit.DependencyInjection.Analyzer/Xunit.DependencyInjection.Analyzer.csproj
+++ b/src/Xunit.DependencyInjection.Analyzer/Xunit.DependencyInjection.Analyzer.csproj
@@ -1,4 +1,4 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
     <IsPackable>false</IsPackable>
@@ -6,7 +6,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.0.1" />
+    <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" />
 
     <Compile Update="AnalyzerResources.Designer.cs" DesignTime="True" AutoGen="True" DependentUpon="AnalyzerResources.resx" />
     <Compile Update="CodeFixResources.Designer.cs" DesignTime="True" AutoGen="True" DependentUpon="CodeFixResources.resx" />
diff --git a/src/Xunit.DependencyInjection.AspNetCoreTesting/Xunit.DependencyInjection.AspNetCoreTesting.csproj b/src/Xunit.DependencyInjection.AspNetCoreTesting/Xunit.DependencyInjection.AspNetCoreTesting.csproj
index cfb116c..bc8ad62 100644
--- a/src/Xunit.DependencyInjection.AspNetCoreTesting/Xunit.DependencyInjection.AspNetCoreTesting.csproj
+++ b/src/Xunit.DependencyInjection.AspNetCoreTesting/Xunit.DependencyInjection.AspNetCoreTesting.csproj
@@ -14,7 +14,7 @@ public class Startup
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" Version="$(_TargetFrameworkVersionWithoutV)" />
+    <PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" />
 
     <ProjectReference Include="..\Xunit.DependencyInjection\Xunit.DependencyInjection.csproj" />
   </ItemGroup>
diff --git a/src/Xunit.DependencyInjection.Demystifier/Xunit.DependencyInjection.Demystifier.csproj b/src/Xunit.DependencyInjection.Demystifier/Xunit.DependencyInjection.Demystifier.csproj
index e7bb6c6..cab45f9 100644
--- a/src/Xunit.DependencyInjection.Demystifier/Xunit.DependencyInjection.Demystifier.csproj
+++ b/src/Xunit.DependencyInjection.Demystifier/Xunit.DependencyInjection.Demystifier.csproj
@@ -14,7 +14,7 @@ public void ConfigureServices(IServiceCollection services)
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Ben.Demystifier" Version="0.*" />
+    <PackageReference Include="Ben.Demystifier" />
 
     <ProjectReference Include="..\Xunit.DependencyInjection\Xunit.DependencyInjection.csproj" />
   </ItemGroup>
diff --git a/src/Xunit.DependencyInjection.Logging/Xunit.DependencyInjection.Logging.csproj b/src/Xunit.DependencyInjection.Logging/Xunit.DependencyInjection.Logging.csproj
index ef42ec4..5f3810a 100644
--- a/src/Xunit.DependencyInjection.Logging/Xunit.DependencyInjection.Logging.csproj
+++ b/src/Xunit.DependencyInjection.Logging/Xunit.DependencyInjection.Logging.csproj
@@ -14,7 +14,7 @@ public void Configure(IServiceProvider provider)
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="MartinCostello.Logging.XUnit" Version="0.*" />
+    <PackageReference Include="MartinCostello.Logging.XUnit" />
 
     <ProjectReference Include="..\Xunit.DependencyInjection\Xunit.DependencyInjection.csproj" />
   </ItemGroup>
diff --git a/src/Xunit.DependencyInjection.SkippableFact/Xunit.DependencyInjection.SkippableFact.csproj b/src/Xunit.DependencyInjection.SkippableFact/Xunit.DependencyInjection.SkippableFact.csproj
index a589ba2..6a240d1 100644
--- a/src/Xunit.DependencyInjection.SkippableFact/Xunit.DependencyInjection.SkippableFact.csproj
+++ b/src/Xunit.DependencyInjection.SkippableFact/Xunit.DependencyInjection.SkippableFact.csproj
@@ -1,4 +1,4 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
     <TargetFrameworks>net472;netstandard2.1</TargetFrameworks>
@@ -14,7 +14,7 @@ public void ConfigureServices(IServiceCollection services)
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Xunit.SkippableFact" Version="1.4.13" />
+    <PackageReference Include="Xunit.SkippableFact" />
 
     <ProjectReference Include="..\Xunit.DependencyInjection\Xunit.DependencyInjection.csproj" />
   </ItemGroup>
diff --git a/src/Xunit.DependencyInjection.StaFact/Xunit.DependencyInjection.StaFact.csproj b/src/Xunit.DependencyInjection.StaFact/Xunit.DependencyInjection.StaFact.csproj
index 748e0f9..e9ec99d 100644
--- a/src/Xunit.DependencyInjection.StaFact/Xunit.DependencyInjection.StaFact.csproj
+++ b/src/Xunit.DependencyInjection.StaFact/Xunit.DependencyInjection.StaFact.csproj
@@ -1,4 +1,4 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
     <TargetFrameworks>net472;netstandard2.1</TargetFrameworks>
@@ -19,7 +19,7 @@ Not support:
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Xunit.StaFact" Version="1.1.11" />
+    <PackageReference Include="Xunit.StaFact" />
 
     <ProjectReference Include="..\Xunit.DependencyInjection\Xunit.DependencyInjection.csproj" />
   </ItemGroup>
diff --git a/src/Xunit.DependencyInjection.xRetry/Xunit.DependencyInjection.xRetry.csproj b/src/Xunit.DependencyInjection.xRetry/Xunit.DependencyInjection.xRetry.csproj
index f0076e0..dfb0568 100644
--- a/src/Xunit.DependencyInjection.xRetry/Xunit.DependencyInjection.xRetry.csproj
+++ b/src/Xunit.DependencyInjection.xRetry/Xunit.DependencyInjection.xRetry.csproj
@@ -15,8 +15,8 @@ public void ConfigureServices(IServiceCollection services)
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="xRetry" Version="[1.9.0, 2.0.0)" />
-    <PackageReference Include="xunit.core" Version="[2.4.2, 3.0.0)" />
+    <PackageReference Include="xRetry" />
+    <PackageReference Include="xunit.core" />
 
     <ProjectReference Include="..\Xunit.DependencyInjection\Xunit.DependencyInjection.csproj" />
   </ItemGroup>
diff --git a/src/Xunit.DependencyInjection/Xunit.DependencyInjection.csproj b/src/Xunit.DependencyInjection/Xunit.DependencyInjection.csproj
index 7a7faee..e04311d 100644
--- a/src/Xunit.DependencyInjection/Xunit.DependencyInjection.csproj
+++ b/src/Xunit.DependencyInjection/Xunit.DependencyInjection.csproj
@@ -1,4 +1,4 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
     <TargetFrameworks>net472;netstandard2.1</TargetFrameworks>
@@ -36,8 +36,8 @@ Release notes:
     <InternalsVisibleTo Include="Xunit.DependencyInjection.StaFact" />
     <InternalsVisibleTo Include="Xunit.DependencyInjection.Test" />
 
-    <PackageReference Include="Microsoft.Extensions.Hosting" Version="8.0.0" />
-    <PackageReference Include="xunit.extensibility.execution" Version="[2.4.2, 3.0.0)" />
+    <PackageReference Include="Microsoft.Extensions.Hosting" />
+    <PackageReference Include="xunit.extensibility.execution" />
 
     <ProjectReference Include="..\Xunit.DependencyInjection.Analyzer\Xunit.DependencyInjection.Analyzer.csproj" PrivateAssets="All" />
   </ItemGroup>
diff --git a/test/TestPackages.targets b/test/TestPackages.targets
index 15f75bc..e5050b7 100644
--- a/test/TestPackages.targets
+++ b/test/TestPackages.targets
@@ -1,9 +1,9 @@
 <Project>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.*" />
-    <PackageReference Include="xunit" Version="2.*" />
-    <PackageReference Include="xunit.runner.visualstudio" Version="2.*" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" />
+    <PackageReference Include="xunit" />
+    <PackageReference Include="xunit.runner.visualstudio" />
   </ItemGroup>
 
 </Project>
diff --git a/test/Xunit.DependencyInjection.Analyzer.Test/Xunit.DependencyInjection.Analyzer.Test.csproj b/test/Xunit.DependencyInjection.Analyzer.Test/Xunit.DependencyInjection.Analyzer.Test.csproj
index 7264bb8..9846836 100644
--- a/test/Xunit.DependencyInjection.Analyzer.Test/Xunit.DependencyInjection.Analyzer.Test.csproj
+++ b/test/Xunit.DependencyInjection.Analyzer.Test/Xunit.DependencyInjection.Analyzer.Test.csproj
@@ -17,12 +17,12 @@
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </Content>
 
-    <PackageReference Include="Microsoft.CodeAnalysis" Version="4.*" />
+    <PackageReference Include="Microsoft.CodeAnalysis" />
 
-    <!--https://github.com/dotnet/roslyn-sdk/blob/main/src/Microsoft.CodeAnalysis.Testing/README.md-->
-    <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Analyzer.Testing" Version="1.*" />
-    <PackageReference Include="Microsoft.CodeAnalysis.CSharp.CodeFix.Testing" Version="1.*" />
-    <PackageReference Include="Microsoft.CodeAnalysis.CSharp.CodeRefactoring.Testing" Version="1.*" />
+    <!-- https://github.com/dotnet/roslyn-sdk/blob/main/src/Microsoft.CodeAnalysis.Testing/README.md -->
+    <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Analyzer.Testing" />
+    <PackageReference Include="Microsoft.CodeAnalysis.CSharp.CodeFix.Testing" />
+    <PackageReference Include="Microsoft.CodeAnalysis.CSharp.CodeRefactoring.Testing" />
   </ItemGroup>
 
   <ItemGroup>
diff --git a/test/Xunit.DependencyInjection.Test.FSharp/Xunit.DependencyInjection.Test.FSharp.fsproj b/test/Xunit.DependencyInjection.Test.FSharp/Xunit.DependencyInjection.Test.FSharp.fsproj
index cc40d03..27da156 100644
--- a/test/Xunit.DependencyInjection.Test.FSharp/Xunit.DependencyInjection.Test.FSharp.fsproj
+++ b/test/Xunit.DependencyInjection.Test.FSharp/Xunit.DependencyInjection.Test.FSharp.fsproj
@@ -15,6 +15,11 @@
   <Import Project="..\..\src\Xunit.DependencyInjection\Xunit.DependencyInjection.targets" />
   <Import Project="..\TestPackages.targets" />
 
+  <ItemGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETFramework'">
+    <PackageReference Include="System.Threading.Tasks.Extensions" />
+    <PackageReference Include="System.ValueTuple" />
+  </ItemGroup>
+
   <ItemGroup>
     <Compile Include="AssemblyNamespaceTest.fs" />
     <Compile Include="ModuleTest.fs" />
@@ -23,9 +28,6 @@
     <Compile Include="ScopedTest.fs" />
     <Compile Include="Program.fs" />
 
-    <PackageReference Include="System.Threading.Tasks.Extensions" Version="4.*" Condition="'$(TargetFrameworkIdentifier)' == '.NETFramework'" />
-    <PackageReference Include="System.ValueTuple" Version="4.*" Condition="'$(TargetFrameworkIdentifier)' == '.NETFramework'" />
-
     <ProjectReference Include="..\..\src\Xunit.DependencyInjection\Xunit.DependencyInjection.csproj" />
   </ItemGroup>
 
diff --git a/test/Xunit.DependencyInjection.Test/Xunit.DependencyInjection.Test.csproj b/test/Xunit.DependencyInjection.Test/Xunit.DependencyInjection.Test.csproj
index c25e262..4db12e0 100644
--- a/test/Xunit.DependencyInjection.Test/Xunit.DependencyInjection.Test.csproj
+++ b/test/Xunit.DependencyInjection.Test/Xunit.DependencyInjection.Test.csproj
@@ -23,9 +23,9 @@
 
     <None Update="appsettings.json" CopyToOutputDirectory="PreserveNewest" />
 
-    <PackageReference Include="Autofac.Extensions.DependencyInjection" Version="9.*" />
-    <PackageReference Include="FluentAssertions" Version="6.*" />
-    <PackageReference Include="FSharp.Core" Version="8.*" />
+    <PackageReference Include="Autofac.Extensions.DependencyInjection" />
+    <PackageReference Include="FluentAssertions" />
+    <PackageReference Include="FSharp.Core" />
 
     <ProjectReference Include="..\..\src\Xunit.DependencyInjection.Demystifier\Xunit.DependencyInjection.Demystifier.csproj" />
     <ProjectReference Include="..\Xunit.DependencyInjection.FakeTest\Xunit.DependencyInjection.FakeTest.csproj" />

From be7e051757c3922f44f84bbcb68328ebf0584023 Mon Sep 17 00:00:00 2001
From: Weihan Li <weihanli@outlook.com>
Date: Fri, 21 Jun 2024 08:56:32 +0800
Subject: [PATCH 2/2] update Directory.Packages.props

---
 Directory.Packages.props | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/Directory.Packages.props b/Directory.Packages.props
index e58a277..9f9156c 100644
--- a/Directory.Packages.props
+++ b/Directory.Packages.props
@@ -5,29 +5,29 @@
     <CentralPackageFloatingVersionsEnabled>true</CentralPackageFloatingVersionsEnabled>
   </PropertyGroup>
   <ItemGroup>
-    <PackageVersion Include="xRetry" Version="[1.9.0, 2.0.0)" />
-    <PackageVersion Include="xunit.core" Version="[2.4.2, 3.0.0)" />
-  
     <PackageVersion Include="Autofac.Extensions.DependencyInjection" Version="9.*" />
     <PackageVersion Include="FluentAssertions" Version="6.*" />
     <PackageVersion Include="FSharp.Core" Version="8.*" />
     
     <PackageVersion Include="Microsoft.CodeAnalysis" Version="4.*" />
-
+    <PackageVersion Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.0.1" />
+    
     <!-- https://github.com/dotnet/roslyn-sdk/blob/main/src/Microsoft.CodeAnalysis.Testing/README.md -->
     <PackageVersion Include="Microsoft.CodeAnalysis.CSharp.Analyzer.Testing" Version="1.*" />
     <PackageVersion Include="Microsoft.CodeAnalysis.CSharp.CodeFix.Testing" Version="1.*" />
     <PackageVersion Include="Microsoft.CodeAnalysis.CSharp.CodeRefactoring.Testing" Version="1.*" />
   
     <PackageVersion Include="Ben.Demystifier" Version="0.*" />
-    <PackageVersion Include="coverlet.collector" Version="6.0.2" />
+    <PackageVersion Include="coverlet.collector" Version="6.*" />
     <PackageVersion Include="MartinCostello.Logging.XUnit" Version="0.*" />
     <PackageVersion Include="Microsoft.AspNetCore.Mvc.Testing" Version="$(_TargetFrameworkVersionWithoutV)" />
-    <PackageVersion Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.0.1" />
     <PackageVersion Include="Microsoft.Extensions.Hosting" Version="8.0.0" />
+
     <PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.*" />
     <PackageVersion Include="xunit" Version="2.*" />
+    <PackageVersion Include="xunit.core" Version="[2.4.2, 3.0.0)" />
     <PackageVersion Include="xunit.extensibility.execution" Version="[2.4.2, 3.0.0)" />
+    <PackageVersion Include="xRetry" Version="[1.9.0, 2.0.0)" />
     <PackageVersion Include="xunit.runner.visualstudio" Version="2.*" />
     <PackageVersion Include="Xunit.DependencyInjection" Version="9.0.0" />
     <PackageVersion Include="Xunit.SkippableFact" Version="1.4.13" />