Bug in listing daemonset pods

[andrewtengson]

In https://github.com/pelotech/nidhogg/blob/main/pkg/nidhogg/handler.go#L256, there's a bug in the pod matching loop where the address of the loop variable is being appended to the matchingPods slice. This results in all elements of matchingPods pointing to the same memory location (the last processed pod), rather than distinct pods.

Possible fix is to copy the pod to a new variable before appending it to the list:

  matchingPods := make([]*corev1.Pod, 0)
  for _, pod := range pods.Items {
    for _, owner := range pod.OwnerReferences {
      if owner.Name == ds.Name && pod.Spec.NodeName == nodeName {
        p := pod
        matchingPods = append(matchingPods, &p)
      }
    }
  }

See: https://stackoverflow.com/questions/45967305/copying-the-address-of-a-loop-variable-in-go