Fix issue when listing daemonset pods

scoquelin · scoquelin · commit 125cac10a065 · 2024-08-08T14:09:29.000-07:00
diff --git a/pkg/nidhogg/handler.go b/pkg/nidhogg/handler.go
@@ -250,10 +250,10 @@ func (h *Handler) getDaemonsetPods(ctx context.Context, nodeName string, ds Daem
 	}
 
 	matchingPods := make([]*corev1.Pod, 0)
-	for _, pod := range pods.Items {
+	for i, pod := range pods.Items {
 		for _, owner := range pod.OwnerReferences {
 			if owner.Name == ds.Name && pod.Spec.NodeName == nodeName {
-				matchingPods = append(matchingPods, &pod)
+				matchingPods = append(matchingPods, &pods.Items[i])
 			}
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -250,10 +250,10 @@ func (h *Handler) getDaemonsetPods(ctx context.Context, nodeName string, ds Daem`
`250`	`250`	`}`
`251`	`251`
`252`	`252`	`matchingPods := make([]*corev1.Pod, 0)`
`253`		`- for _, pod := range pods.Items {`
	`253`	`+ for i, pod := range pods.Items {`
`254`	`254`	`for _, owner := range pod.OwnerReferences {`
`255`	`255`	`if owner.Name == ds.Name && pod.Spec.NodeName == nodeName {`
`256`		`- matchingPods = append(matchingPods, &pod)`
	`256`	`+ matchingPods = append(matchingPods, &pods.Items[i])`
`257`	`257`	`}`
`258`	`258`	`}`
`259`	`259`	`}`