Merge pull request #197 from Mingun/fix-message-regression

Fix a regression in the description of character classes in error message

Author: hildjj

CHANGELOG.md

@@ -24,6 +24,8 @@ Released: TBD
 
 - [#164](https://github.com/peggyjs/peggy/pull/164): Fix some errors in the typescript definitions
 - [#169](https://github.com/peggyjs/peggy/issues/169): Expose string escape functions
+- [#197](https://github.com/peggyjs/peggy/pull/197): Fix a regression of redundant commas in the
+  character classes in the error messages, introduced in fad4ab74d1de67ef1902cd22d479c81ccab73224
 
 1.2.0
 -----

lib/compiler/passes/generate-js.js

@@ -657,7 +657,7 @@ function generateJS(ast, options) {
       "          : classEscape(part);",
       "      });",
       "",
-      "      return \"[\" + (expectation.inverted ? \"^\" : \"\") + escapedParts + \"]\";",
+      "      return \"[\" + (expectation.inverted ? \"^\" : \"\") + escapedParts.join(\"\") + \"]\";",
       "    },",
       "",
       "    any: function() {",

test/api/generated-parser-api.spec.js

@@ -20,6 +20,13 @@ describe("generated parser API", () => {
       expect(() => { parser.parse("b"); }).to.throw();
     });
 
+    // Regression: https://github.com/peggyjs/peggy/pull/197
+    it("correctly describe character class in syntax error", () => {
+      const parser = peg.generate("start = [123-5]");
+
+      expect(() => { parser.parse("0"); }).to.throw("[123-5]");
+    });
+
     describe("start rule", () => {
       const parser = peg.generate([
         "a = 'x' { return 'a'; }",