Japanese text conversion input #107
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please clean up - lots of files are not necessary - follow the best practices and look at other components |
|
overall - you should remove the other components like password input or mask input and follow the same practice |
mitsuyapega
changed the title
Sujesh95
reviewed
Dec 11, 2024
| interface PegaExtensionsJapaneseInputProps { | ||
| // If any, enter additional props that only exist on TextInput here | ||
| hasSuggestions?: boolean; | ||
| variant?: any; |
There was a problem hiding this comment.
Provide appropriate types in the place of any
Sujesh95
reviewed
Dec 11, 2024
| import '../create-nonce'; | ||
|
|
||
| // interface for props | ||
| interface PegaExtensionsJapaneseInputProps { |
There was a problem hiding this comment.
export the interface incase we need it.
Sujesh95
reviewed
Dec 11, 2024
| import '../create-nonce'; | ||
|
|
||
| // interface for props | ||
| interface PegaExtensionsJapaneseInputProps { |
There was a problem hiding this comment.
extend InputProps from @pega/cosmos-react-core. In that case, you can remove duplicate types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an input with the following 3 features. All of them convert characters with onBlur.
Converts Lowercase to Uppercase, for when the client inputs lowercase and the internal character handles it as uppercase.
Japanese has two types of characters, Hiragana and Katakana, which correspond one-to-one. Hiragana input is converted to Katakana.
In Japanese, characters are generally handled as multi-byte full-width characters rather than single-byte half-width characters, and for this reason Japanese keyboards have a function to input characters in full-width. Some full-width characters have the same meaning in half-width, and these are converted from full-width to half-width.