Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated transitive dependency with security alerts [unzipper] #3080

Open
1 task done
Araxeus opened this issue Jun 5, 2024 · 0 comments
Open
1 task done

Deprecated transitive dependency with security alerts [unzipper] #3080

Araxeus opened this issue Jun 5, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@Araxeus
Copy link

Araxeus commented Jun 5, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

Unzipper uses the deprecated module fstream (https://www.npmjs.com/package/fstream)
which has several CVE's and bugs,(ZJONSSON/node-unzipper#261)

We should probably use https://www.npmjs.com/package/adm-zip or https://www.npmjs.com/package/archiver

there is also a bug in fstream where it doesnt use mkdirp in the right way (atleast when using bun):

image

can be fixed by changing

- mkdir(path.dirname(self._path), Writer.dirmode, function (er, made) {
+ mkdir.mkdirp(path.dirname(self._path), Writer.dirmode, function (er, made) {

in https://github.com/npm/fstream/blob/bffea43c6a201c76bc85842539e09a779508790b/lib/writer.js#L169


I fix it by using this fork: https://github.com/Araxeus/whatsapp-web.js/tree/webpack-exodus-fix-zip

  "dependencies": {,
    "whatsapp-web.js": "github:araxeus/whatsapp-web.js#webpack-exodus-fix-zip"
  },
@Araxeus Araxeus added the bug Something isn't working label Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant