Feature, solid background #83 #84
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedromassango
requested changes
Jun 22, 2021
Comment on lines
+25
to
+26
| }) : assert(items.length >= 2 && items.length <= 5), | ||
| super(key: key); |
| @@ -217,4 +223,7 @@ class BottomNavyBarItem { | |||
| /// This will take effect only if [title] it a [Text] widget. | |||
| final TextAlign? textAlign; | |||
|
|
|||
| /// The [background] solid color defined when this item is selected. Defaults | |||
| /// to [false]. | |||
| final bool solidBackground; | |||
There was a problem hiding this comment.
Maybe change it to: If [true], use the solid color for the background of this item. Defaults to [false].
Comment on lines
+162
to
+164
| ? item.solidBackground | ||
| ? Colors.white | ||
| : item.activeColor.withOpacity(1) |
There was a problem hiding this comment.
I'm a bit confused, the property is called solidBackground but it changes the color of the icon as well. You can either rename the property name to something like useSolidColors or revert this change.
Comment on lines
+177
to
+179
| color: item.solidBackground | ||
| ? Colors.white | ||
| : item.activeColor, |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #83