Skip to content

Commit eecab57

Browse files
Edsunsalshedivat
authored andcommitted
Optimize dark theme (alshedivat#431)
* Optimize dark theme * Fix-up * Minor fixes Co-authored-by: Maruan Al-Shedivat <[email protected]>
1 parent 6341493 commit eecab57

File tree

2 files changed

+18
-8
lines changed

2 files changed

+18
-8
lines changed

_sass/_base.scss

+16-8
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,10 @@ p, h1, h2, h3, h4, h5, h6, em, div, li, span, strong {
88
color: var(--global-text-color);
99
}
1010

11+
hr {
12+
border-top: 1px solid var(--global-divider-color);
13+
}
14+
1115
a, table.table a {
1216
color: var(--global-theme-color);
1317
&:hover {
@@ -91,18 +95,22 @@ blockquote {
9195

9296
.navbar {
9397
box-shadow: none;
94-
border-bottom: 1px solid $grey-color-light;
98+
border-bottom: 1px solid var(--global-divider-color);
9599
background-color: var(--global-bg-color);
96100
opacity: 0.95;
97101
}
98102
.navbar .dropdown-menu {
99103
background-color: var(--global-bg-color);
104+
border: 1px solid var(--global-divider-color);
100105
a:not(.active) {
101106
color: var(--global-text-color);
102107
}
103108
a:hover {
104109
color: var(--global-hover-color);
105110
}
111+
.dropdown-divider {
112+
border-top: 1px solid var(--global-divider-color) !important;
113+
}
106114
}
107115
.dropdown-item {
108116
color: var(--global-text-color);
@@ -243,7 +251,7 @@ footer.fixed-bottom {
243251
}
244252

245253
footer.sticky-bottom {
246-
border-top: 1px solid $grey-color-light;
254+
border-top: 1px solid var(--global-divider-color);
247255
padding-top: 40px;
248256
padding-bottom: 40px;
249257
font-size: 0.9rem;
@@ -253,7 +261,7 @@ footer.sticky-bottom {
253261
// Blog
254262

255263
.header-bar {
256-
border-bottom: 1px solid $grey-color-light;
264+
border-bottom: 1px solid var(--global-divider-color);
257265
text-align: center;
258266
padding-top: 2rem;
259267
padding-bottom: 5rem;
@@ -268,7 +276,7 @@ footer.sticky-bottom {
268276
margin-bottom: 40px;
269277
padding: 0;
270278
li {
271-
border-bottom: 1px solid $grey-color-light;
279+
border-bottom: 1px solid var(--global-divider-color);
272280
list-style: none;
273281
padding-top: 2rem;
274282
padding-bottom: 2rem;
@@ -359,8 +367,8 @@ footer.sticky-bottom {
359367
}
360368

361369
h2.category {
362-
color: $grey-color-light;
363-
border-bottom: 1px solid $grey-color-light;
370+
color: var(--global-divider-color);
371+
border-bottom: 1px solid var(--global-divider-color);
364372
padding-top: 0.5rem;
365373
margin-top: 2rem;
366374
margin-bottom: 1rem;
@@ -387,8 +395,8 @@ footer.sticky-bottom {
387395
}
388396
}
389397
h2.year {
390-
color: $grey-color-light;
391-
border-top: 1px solid $grey-color-light;
398+
color: var(--global-divider-color);
399+
border-top: 1px solid var(--global-divider-color);
392400
padding-top: 1rem;
393401
margin-top: 2rem;
394402
margin-bottom: -2rem;

_sass/_themes.scss

+2
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
--global-footer-text-color: #{$grey-color-light};
1414
--global-footer-link-color: #{$white-color};
1515
--global-distill-app-color: #{$grey-color};
16+
--global-divider-color: rgba(0,0,0,.1);
1617

1718
.fa-sun {
1819
display : none;
@@ -35,6 +36,7 @@ html[data-theme='dark'] {
3536
--global-footer-text-color: #{$grey-color-dark};
3637
--global-footer-link-color: #{$black-color};
3738
--global-distill-app-color: #{$grey-color-light};
39+
--global-divider-color: #424246;
3840

3941
.fa-sun {
4042
padding-left: 10px;

0 commit comments

Comments
 (0)