Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fade : Text appearing in this array order : 0,2,4,1,3 #31

Open
kahsky opened this issue Oct 12, 2015 · 1 comment
Open

Fade : Text appearing in this array order : 0,2,4,1,3 #31

kahsky opened this issue Oct 12, 2015 · 1 comment

Comments

@kahsky
Copy link

kahsky commented Oct 12, 2015

Time!

The total execution time of the rotate function is the same as the time of the fadein fadeout functions. This can't work.
To change: the time should be divided by 2 for fade in and fade out functions.

@davidwhyte
Copy link

davidwhyte commented Apr 16, 2018

Fixed this by taking into account the tip by @kahsky.
Just replace the fade section of the code with the code below.
That fixed the issue for the fade transition.

case 'fade':
     el.stop().fadeOut(settings.speed / 2, function() { 
          index = $.inArray(el.text(), array)
         if((index + 1) == array.length) index = -1
         el.text(array[index + 1]).stop().fadeIn(settings.speed / 2);
     });
break;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants