Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test unclickable false #2

Open
peaceiris opened this issue Sep 17, 2020 · 1 comment
Open

test unclickable false #2

peaceiris opened this issue Sep 17, 2020 · 1 comment
Assignees

Comments

@peaceiris
Copy link
Owner

peaceiris commented Sep 17, 2020

Description

Currently, all files that are set to be ignored in .gitignore will not be deployed by the action. This seems to be caused by the git clone operation and, while I haven't been able to find any discussion on this in issues or PRs (I used github's search tool, so I might be on the wrong here), I think it's safe to assume that this is the intended behaviour.

I believe that this behaviour could be counterintuitive to some users, so it may be interesting to document it on the readme, or at least discuss the idea here.

Reproduction

  1. Create a repository that includes a .gitignore file that blacklists some files
  2. Set up a CI pipeline that deploys the directory that contains the .gitignore file using this action
  3. Files specified on .gitignore will not be deployed

You can see this behaviour on this CI run.

Reasons why this can be unexpected

I personally got confused by this behaviour, as I expected .gitignored files to be deployed. My thought process went along the lines of:

  1. People usually deploy build artifacts
  2. Build artifacts are usually excluded from git through .gitignore
  3. Thus, .gitignore files are probably not ignored when deploying
@peaceiris peaceiris self-assigned this Sep 17, 2020
@github-actions
Copy link

Repository owner locked and limited conversation to collaborators Sep 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant