Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add GitHub documentation references to permissions #754

Merged
merged 1 commit into from
May 17, 2022

Conversation

zhouzi
Copy link
Contributor

@zhouzi zhouzi commented May 16, 2022

As pointed in #752, #753 and initially reported in #744, there are two ways to configure the permissions. This PR adds links to GitHub's documentation for more details. It also removes the screenshot for configuring the GITHUB_TOKEN's default permissions and points to the documentation instead of sharing the procedure. The idea is to encourage using the permissions.content approach which seem more secure.

That's just my 2 cents though.

Copy link
Owner

@peaceiris peaceiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks

@peaceiris peaceiris changed the title Add GitHub documentation references to permissions docs: Add GitHub documentation references to permissions May 17, 2022
@peaceiris peaceiris merged commit ac45008 into peaceiris:main May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants