Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Although enable_jekyll is set to false (by default), I don't see a .nojekyll file. #437

Closed
1 task done
dimitribouniol opened this issue Aug 1, 2020 · 4 comments
Closed
1 task done
Assignees
Labels

Comments

@dimitribouniol
Copy link

Check list before opening this issue

Describe your question

This is my first time using a workflow, and I'm surprised how easy this made getting a quick site up and running! That said, I did notice that although enable_jekyll is set to false (by default), I don't see a .nojekyll file in the resulting repo (The one I had placed previously was actually removed). According to https://github.com/peaceiris/actions-gh-pages#%EF%B8%8F-enable-built-in-jekyll-enable_jekyll, this should just work.

Here are the inputs from my run:

 Deploy to GitHub Pages 5s
31
  
1
Run peaceiris/actions-gh-pages@v3
15
Dump inputs
16
  [INFO] DeployKey: true
17
  [INFO] PublishBranch: main
18
  [INFO] PublishDir: ./Output
19
  [INFO] ExternalRepository: example/example.github.io
20
  [INFO] AllowEmptyCommit: false
21
  [INFO] KeepFiles: false
22
  [INFO] ForceOrphan: false
23
  [INFO] UserName: 
24
  [INFO] UserEmail: 
25
  [INFO] CommitMessage: Added GitHub Action to auto deploy the site
26
  [INFO] FullCommitMessage: 
27
  [INFO] TagName: 
28
  [INFO] TagMessage: 
29
  [INFO] EnableJekyll (DisableNoJekyll): false
30
  [INFO] CNAME: example.com

I hope I just missed something silly!

Link to your contents

name: GitHub Pages

on:
  push:
    branches:
      - main

jobs:
  deploy:
    runs-on: ubuntu-18.04
    steps:
      - name: Checkout Source
        uses: actions/checkout@v2

      - name: Setup JohnSundell/Publish
        run: |
          cd ${HOME}
          git clone --depth=1 https://github.com/JohnSundell/Publish.git
          cd ./Publish
          swift build -c release
          echo "::add-path::${HOME}/Publish/.build/release"

      - run: publish-cli generate

      - name: Deploy to GitHub Pages
        uses: peaceiris/actions-gh-pages@v3
        with:
          deploy_key: ${{ secrets.ACTIONS_DEPLOY_KEY }}
          external_repository: example/example.github.io
          publish_branch: main
          publish_dir: ./Output
          cname: example.com
          commit_message: ${{ github.event.head_commit.message }}

Screenshots

image

Additional context

@peaceiris
Copy link
Owner

peaceiris commented Aug 2, 2020

Related to #436

README.md

By default, this action signals to GitHub Pages that the site shall not be processed with Jekyll. This is done by adding an empty .nojekyll file when publishing to the master or gh-pages branch. When a .nojekyll file already exists, this action does nothing.

Build and deploy GitHub Pages from any branch beta The GitHub Blog

This action has not supported this beta feature yet.

@peaceiris
Copy link
Owner

The version v3.7.0-7 supports this now.

@dimitribouniol
Copy link
Author

Neat, it seems like I started using Github Pages right as this all started changing over 😅 I'll let you know if I still don't see it the next time I update the site. Thank you for your help!

@github-actions
Copy link
Contributor

This issue has been LOCKED because of it being resolved!

The issue has been fixed and is therefore considered resolved.
If you still encounter this or it has changed, open a new issue instead of responding to solved ones.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants