Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove warning about GITHUB_TOKEN #108

Merged
merged 1 commit into from
Feb 19, 2020

Conversation

peaceiris
Copy link
Owner

GitHub might have started to supporting to trigger the GitHub Pages build event by GITHUB_TOKEN on public repositories. (We can already use the token on private repositories.) Be careful, there is no official announcement about this by GitHub.

cf. #9

@peaceiris
Copy link
Owner Author

Unfortunately, the build with GITHUB_TOKEN failed today...

Keep this Pull Request.

@peaceiris peaceiris changed the title feat: Remove warning about GITHUB_TOKEN [WIP] feat: Remove warning about GITHUB_TOKEN Feb 18, 2020
GitHub might have started to supporting to trigger the GitHub Pages build event by GITHUB_TOKEN on public repositories. (We can already use the token on private repositories.) Be careful, there is no official announcement about this by GitHub.

cf. #9
@peaceiris peaceiris force-pushed the feat-remove-github-token-warning branch from f009bab to fd6489e Compare February 19, 2020 14:09
@peaceiris
Copy link
Owner Author

peaceiris commented Feb 19, 2020

OK. I will merge this. If something wrong occurs with GITHUB_TOKEN on public repositories, we can revert this.

@peaceiris peaceiris merged commit 74f652a into master Feb 19, 2020
@peaceiris peaceiris deleted the feat-remove-github-token-warning branch February 19, 2020 14:22
@peaceiris peaceiris changed the title [WIP] feat: Remove warning about GITHUB_TOKEN feat: Remove warning about GITHUB_TOKEN Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant