Skip to content

sql prepared statement #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2020
Merged

sql prepared statement #1

merged 1 commit into from
Apr 30, 2020

Conversation

@alikon
Copy link

@alikon alikon commented Apr 30, 2020

Summary of Changes

used the prepared statement for where clause

Expected result

work as before

pe7er
pe7er approved these changes Apr 30, 2020
View reviewed changes
Copy link
Owner

@pe7er pe7er left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alikon !

@pe7er pe7er merged commit d951e96 into pe7er:menu-items-overview-filter-on-component Apr 30, 2020
@alikon alikon deleted the patch-109 branch April 30, 2020 08:35
pe7er pushed a commit that referenced this pull request Feb 2, 2022
@dgrammatiko @brianteeman
@bembelimen @PhilETaylor @richard67
[4.1] Child templates 2/2 [clean] (joomla#35998)
3ff973c 
* Fix the missing installer info

* Fix the template thumb images

* Fix missing language on style view

* Update Templates.php

* Update libraries/src/Installer/Installer.php

Co-authored-by: Brian Teeman <[email protected]>

* Update build/media_source/system/images/template_thumb.svg

Co-authored-by: Brian Teeman <[email protected]>

* Update build/media_source/system/images/template_thumb.svg

Co-authored-by: Brian Teeman <[email protected]>

* Fix the thumb logic

* editor #1

* CS

* CS

* CS + fix logic

* Ensure the isMedia flag is correcly propageted

* Ooops, forgot the child creation functionality

From joomla#35879

* CS

* Update administrator/components/com_templates/tmpl/template/default_modal_child_body.php

Co-authored-by: Brian Teeman <[email protected]>

* Update administrator/components/com_templates/tmpl/template/default_modal_child_footer.php

Co-authored-by: Brian Teeman <[email protected]>

* Fix the description for the child name

* Update administrator/components/com_templates/tmpl/template/default_media_folders.php

Co-authored-by: Brian Teeman <[email protected]>

* Update administrator/components/com_templates/tmpl/template/default_tree_media.php

Co-authored-by: Brian Teeman <[email protected]>

* Fix copy/pasting doc blocks

* Child tmpl name === parentTmplName_childName

* Update administrator/components/com_templates/src/Model/TemplateModel.php

Co-authored-by: Brian Teeman <[email protected]>

* Update administrator/components/com_templates/src/Model/TemplateModel.php

Co-authored-by: Brian Teeman <[email protected]>

* Update administrator/components/com_templates/src/Model/TemplateModel.php

Co-authored-by: Brian Teeman <[email protected]>

* Update administrator/components/com_templates/src/View/Template/HtmlView.php

Co-authored-by: Brian Teeman <[email protected]>

* CS

* Update administrator/components/com_templates/src/Service/HTML/Templates.php

Co-authored-by: Quy <[email protected]>

* Update administrator/components/com_templates/src/Controller/TemplateController.php

Co-authored-by: Benjamin Trenkle <[email protected]>

* Bailout Early

* CS

* Don't throw warnings

* better conditianal

* More notices

* Fix the thumb paths

* Fix Fat FS lookups

* Fix the missing media folder for the child template

* don't echo the first slash on win OS

* .html is not in the allowed list. WOW

* Update administrator/components/com_templates/src/Model/TemplateModel.php

Co-authored-by: Phil E. Taylor <[email protected]>

* Update administrator/components/com_templates/src/Controller/TemplateController.php

Co-authored-by: Phil E. Taylor <[email protected]>

* Update administrator/components/com_templates/tmpl/template/default_modal_folder_body.php

Co-authored-by: Phil E. Taylor <[email protected]>

* Update administrator/components/com_templates/tmpl/template/default_media_folders.php

Co-authored-by: Phil E. Taylor <[email protected]>

* Update administrator/components/com_templates/tmpl/template/default.php

Co-authored-by: Phil E. Taylor <[email protected]>

* Update administrator/components/com_templates/src/View/Template/HtmlView.php

Co-authored-by: Phil E. Taylor <[email protected]>

* Update administrator/components/com_templates/src/Model/TemplateModel.php

Co-authored-by: Phil E. Taylor <[email protected]>

* Update administrator/components/com_templates/src/Controller/TemplateController.php

Co-authored-by: Phil E. Taylor <[email protected]>

* Update administrator/components/com_templates/src/Model/TemplateModel.php

Co-authored-by: Phil E. Taylor <[email protected]>

* Update administrator/components/com_templates/src/Model/TemplateModel.php

Co-authored-by: Phil E. Taylor <[email protected]>

* CS, proper media folder logic

* CS

* Meh

* Paths...

* better tree entry names

* Use current user name, current date for child

* Bug, file delete

* Fix upload

* Add a visual cue for parent/child

* Add buttons to switch between list views

@bembelimen's idea

* Wrong comments

* Clean up the child method

* PHP notice, use entry dir as the starting point

* Correct icon

* Undefined $isMedia Pfff

* Update administrator/components/com_templates/src/Controller/TemplateController.php

Co-authored-by: Richard Fath <[email protected]>

* Update administrator/components/com_templates/src/Controller/TemplateController.php

Co-authored-by: Richard Fath <[email protected]>

* Merge joomla#36011

* Remove a debug line

* Windows use / instead of \

* Winows double //

* Update administrator/language/en-GB/com_templates.ini

Co-authored-by: Brian Teeman <[email protected]>

* double //

* b->strong

* rename modatl tittle //

* Update administrator/components/com_templates/tmpl/template/default_tree_media.php

Co-authored-by: Quy <[email protected]>

* Update plugins/editors/tinymce/tinymce.php

Co-authored-by: Quy <[email protected]>

* Switch the fallback icon

This has a Creative Commons Zero v1.0 Universal (CC0) license
and it was copied from: https://iconduck.com/search?query=xcode

* Update administrator/components/com_templates/src/View/Styles/HtmlView.php

Co-authored-by: Quy <[email protected]>

* Update administrator/language/en-GB/com_templates.ini

Co-authored-by: Quy <[email protected]>

* Update plugins/editors/tinymce/tinymce.php

Co-authored-by: Quy <[email protected]>

* Update administrator/language/en-GB/com_templates.ini

Co-authored-by: Quy <[email protected]>

* tabs

* Lang failsafe

* Update administrator/components/com_templates/tmpl/template/default_folders.php

Co-authored-by: Quy <[email protected]>

Co-authored-by: Brian Teeman <[email protected]>
Co-authored-by: Quy <[email protected]>
Co-authored-by: Benjamin Trenkle <[email protected]>
Co-authored-by: Phil E. Taylor <[email protected]>
Co-authored-by: Richard Fath <[email protected]>
pe7er pushed a commit that referenced this pull request Feb 2, 2022
@alikon
Deprecated: trim(): Passing null to parameter #1 (joomla#36286)
05cf279
pe7er pushed a commit that referenced this pull request Feb 2, 2022
@alikon
[4] php 8.1 Deprecated: substr(): Passing null to parameter #1 (jooml…
39ec26a 
…a#36285)
pe7er pushed a commit that referenced this pull request Feb 2, 2022
@alikon
[4] php 8.1 Deprecated: trim(): Passing null to parameter #1 (joomla#…
96d115d 
…36284)
pe7er pushed a commit that referenced this pull request Feb 2, 2022
@beat
[3.10] [PHP 8.1] Fixes Table User for Date/Date.php warning on login (j…
aae1bb8 
…oomla#36804)

Fixes `Fixes `Deprecated: DateTime::__construct(): Passing null to parameter #1 ($datetime) of type string is deprecated in libraries/src/Date/Date.php on line 112` error on login`
pe7er pushed a commit that referenced this pull request Feb 2, 2022
@beat
[3.10] [PHP 8.1] fixes all modules Deprecated: htmlspecialchars(): Pa…
e02d637 
…ssing null to type string (joomla#36795)

* [3.10] [PHP 8.1] fixes mod_tags_popular

Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/modules/mod_tags_popular/mod_tags_popular.php on line 29`

* [3.10] [PHP 8.1] fixes mod_breadcrumbs

Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/modules/mod_breadcrumbs/mod_breadcrumbs.php on line 21`

* Update mod_custom.php

Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in modules/mod_custom/mod_custom.php on line 18`

* [3.10] [PHP 8.1] Fixes mod_menu.php

Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in modules/mod_menu/mod_menu.php on line 23`

* [3.10] [PHP 8.1] mod_stats

* [3.10] [PHP 8.1] fixes mod_articles_archive.php

* [3.10] [PHP 8.1] mod_articles_categories.php

* [3.10] [PHP 8.1] fixes mod_articles_category

* [3.10] [PHP 8.1] fixes mod_articles_latest

* [3.10] [PHP 8.1] fixes mod_articles_news

* [3.10] [PHP 8.1] fixes mod_articles_popular

* [3.10] [PHP 8.1] fixes mod_banners

* [3.10] [PHP 8.1] fixes mod_feed

* [3.10] [PHP 8.1] fixes mod_footer

* [3.10] [PHP 8.1] fixes mod_languages

* [3.10] [PHP 8.1] fixes mod_random_image

* [3.10] [PHP 8.1] fixes mod_related_items

* [3.10] [PHP 8.1] fixes mod_syndicate

* [3.10] [PHP 8.1] fixes mod_tags_similar

* [3.10] [PHP 8.1] fixes mod_users_latest

* [3.10] [PHP 8.1] fixes mod_whosonline

* [3.10] [PHP 8.1] fixes mod_wrapper

* [3.10] [PHP 8.1] fixes admin mod_privacy_dashboard

* [3.10] [PHP 8.1] fixes admin mod_feed

* [3.10] [PHP 8.1] fixes admin mod_stats_admin
pe7er pushed a commit that referenced this pull request Feb 2, 2022
@beat
[3.10] [PHP 8.1] Make templates/system/html/modules.php PHP 8.1 compa…
61396f7 
…tible (joomla#36794)

* [3.10] [PHP 8.1] Make templates/system/html/modules.php PHP 8.1 compatible

Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/templates/system/html/modules.php on line 101` and a few more (line 35, line 53, line 115)

* [3.10] [PHP 8.1] Fixes protostar modules.php null string param

Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/templates/protostar/html/modules.php on line 47`

* [3.10] [PHP 8.1] Fixes beez modules.php null string param

Fixes errors like `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in templates/beez/html/modules.php on line 42`
pe7er pushed a commit that referenced this pull request Feb 2, 2022
@beat
[3.10] [PHP 8.1] Fixing mod_search Passing null to type string (jooml…
c0286f0 
…a#36792)

Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/modules/mod_search/mod_search.php on line 44`
pe7er pushed a commit that referenced this pull request Feb 2, 2022
@beat
[3.10] [PHP 8.1] Fixes Table User for Date/Date.php warning on login (j…
d19bbe0 
…oomla#36799)

Fixes `Deprecated: DateTime::__construct(): Passing null to parameter #1 ($datetime) of type string is deprecated in /home/beat/www/j/libraries/src/Date/Date.php on line 112` error on login
pe7er pushed a commit that referenced this pull request Feb 2, 2022
@beat
Update BaseController.php (joomla#36797)
3de1ce1 
Fixes `Deprecated: ucfirst(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/libraries/src/MVC/Controller/BaseController.php on line 286`
and fixes `Deprecated: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/libraries/src/MVC/Controller/BaseController.php on line 684`
pe7er pushed a commit that referenced this pull request Feb 2, 2022
@beat @zero-24
[3.10] [PHP 8.1] Fix Editor Passing null to $string line 258 (joomla#…
b90fb91 
…36777)

* [3.10] [PHP 8.1] Fix Editor Passing null to $string line 258

Fixes `Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in libraries/src/Editor/Editor.php on line 258`

* [PHP 8.1] Editor in backend: Better fix for joomla#36777

Co-authored-by: Tobias Zulauf <[email protected]>

Co-authored-by: Tobias Zulauf <[email protected]>
pe7er pushed a commit that referenced this pull request Feb 2, 2022
@beat
[3.10] [PHP 8.1] Fixes mod_menu/menu.php type null instead of string (j…
0a1c48f 
…oomla#36773)

* [3.10] [PHP 8.1] Fixes mod_menu/menu.php type null instead of string

Fixes Deprecated: trim(): `Passing null to parameter #1 ($string) of type string is deprecated in administrator/modules/mod_menu/menu.php on line 383`

* [PHP 8.1] admin mod_menu: Slightly cleaner fix for joomla#36773
pe7er pushed a commit that referenced this pull request Feb 2, 2022
@beat
[3.10] [PHP 8.1] Fixes com_finder/indexer/query (joomla#36796)
5ed8cdd 
* [3.10] [PHP 8.1] Fixes com_finder/indexer/query

Fixes `Deprecated: html_entity_decode(): Passing null to parameter #1 ($string) of type string is deprecated in administrator/components/com_finder/helpers/indexer/query.php on line 733`

* Better fix for joomla#36796 as suggested by @zero-24
pe7er pushed a commit that referenced this pull request Feb 2, 2022
@beat @zero-24
[3.10] [PHP 8.1] Fixes Router/Route.php deprecated null to string in …
e712ad7 
…strpos() (joomla#36798)

* [3.10] [PHP 8.1] Fixes Router/Route.php deprecated null to string in strpos()

Fixes `Deprecated: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in libraries/src/Router/Route.php on line 124`

* [PHP 8.1] Better fix to avoid deprecation proposed by @zero-24

Co-authored-by: Tobias Zulauf <[email protected]>

* Revert previous commit for different fix in mod_breadcrumbs/helper.php

* [PHP 8.1] Better fix for joomla#36798 mod_breadcrumbs with null link in last item

Co-authored-by: Tobias Zulauf <[email protected]>
pe7er pushed a commit that referenced this pull request Mar 19, 2022
@beat
[PHP 8.1] Fix Deprecated notice: strtolower(): Passing null to string…
03c0fc6 
… is deprecated in components/com_ajax/ajax.php on line 39 (joomla#37007)

Fix Deprecated: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in components/com_ajax/ajax.php on line 39
pe7er pushed a commit that referenced this pull request Apr 20, 2022
@beat
PHP 8.1: Fixes Deprecated: null to string in MailTemplate.php (joomla…
9d13d22 
…#37384)

Fixes "Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in libraries/src/Mail/MailTemplate.php on line 297"
pe7er pushed a commit that referenced this pull request Apr 20, 2022
@beat
Fixes `Deprecated: strtolower(): Passing null to string in libraries/…
761e52e 
…src/Log/Log.php on line 387` (joomla#37009)

Fixes `Deprecated: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in libraries/src/Log/Log.php on line 387`
pe7er pushed a commit that referenced this pull request Aug 23, 2023
@janschoenherr
Prevent Exception (joomla#40122)
652222e 
* Prevent Exception

If $parts is `null` this will throw an exception.

```count(): Argument #1 ($value) must be of type Countable|array, null given```

This can happen if the context is e.g. the default context `text` from the `Joomla\CMS\HTML\Helpers\Content::prepare()` function.

* Update fields.php
pe7er pushed a commit that referenced this pull request Feb 22, 2025
@alikon
[5.2] PHP Deprecated: trim(): Passing null to parameter #1 ($string) …
64ac8c8 
…of type string is deprecated (joomla#44876)
pe7er pushed a commit that referenced this pull request Mar 22, 2025
@brianteeman
[5.3] php 8.4 compatibility (joomla#45169)
bfad6f1 
PHP Deprecated:  strtotime(): Passing null to parameter #1 ($datetime) of type string is deprecated

Signed-off-by: BrianTeeman <[email protected]>
richard67 added a commit that referenced this pull request Apr 26, 2025
@richard67
Revert composer downgrades (#1)
c81df81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pe7er pe7er pe7er approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alikon @pe7er