From 5bd6247bab32f4c4d7866d999719040397d967b5 Mon Sep 17 00:00:00 2001 From: Ada Date: Fri, 13 Feb 2026 21:20:08 -0700 Subject: [PATCH] image_service: embed UnimplementedImageServiceServer for gRPC forward-compat Embed runtime.UnimplementedImageServiceServer in the imageService struct to satisfy the gRPC forward-compatibility requirement introduced in newer versions of k8s.io/cri-api. Without this, projects that compile nix-snapshotter against k8s >= 1.34 CRI API fail with: cannot use service (variable of type *imageService) as runtime.ImageServiceServer value: missing method mustEmbedUnimplementedImageServiceServer This is a no-op for existing functionality since all required interface methods are already implemented. Co-Authored-By: Joshua Perry --- pkg/nix/image_service.go | 1 + 1 file changed, 1 insertion(+) diff --git a/pkg/nix/image_service.go b/pkg/nix/image_service.go index f51e8e4..d327b06 100644 --- a/pkg/nix/image_service.go +++ b/pkg/nix/image_service.go @@ -31,6 +31,7 @@ type ImageServiceOpt interface { } type imageService struct { + runtime.UnimplementedImageServiceServer mu sync.Mutex client *client.Client imageServiceClient runtime.ImageServiceClient