From 001dfc80a1d29f0e9e64d6f9c6d9e1098d0479ba Mon Sep 17 00:00:00 2001 From: Frost Ming Date: Thu, 8 Jun 2023 11:48:36 +0800 Subject: [PATCH] fix: raise an error when SCM version can't be determined (#180) --- src/pdm/backend/hooks/version/scm.py | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/pdm/backend/hooks/version/scm.py b/src/pdm/backend/hooks/version/scm.py index 7ed9ee5..64c975d 100644 --- a/src/pdm/backend/hooks/version/scm.py +++ b/src/pdm/backend/hooks/version/scm.py @@ -332,8 +332,9 @@ def get_version_from_scm(root: str | Path, *, tag_regex: str | None = None) -> s for func in (git_parse_version, hg_parse_version): version = func(root, config) # type: ignore if version: - break - else: - version = meta(config, "0.0.0") - assert version is not None - return format_version(version) + return format_version(version) + raise ValueError( + "Cannot find the version from SCM or SCM isn't detected. \n" + "You can still specify the version via environment variable " + "`PDM_BUILD_SCM_VERSION`." + )