From a9f8c8920cd80d03535dda6fd6f46a0db07c3947 Mon Sep 17 00:00:00 2001 From: Sergey Biryukov Date: Thu, 8 Sep 2022 16:43:01 +0000 Subject: [PATCH] Global Styles: Add support for `heading`, `button`, and `caption` elements. This enables themes to: * Set style rules for all heading elements together rather than having to do it individually. * Style captions in `theme.json` by adding this into your `theme.json` file: {{{ { "styles": { "elements": { "caption": { "color": { "background": "red", "text": "yellow" } } } } } }}} This commit backports the original PRs from Gutenberg repository: * [https://github.com/WordPress/gutenberg/pull/41981 #41981: Global Styles: Add support for heading elements] * [https://github.com/WordPress/gutenberg/pull/41140 #41140: Global Styles: Add support for caption elements] Follow-up to [50973]. Props cbravobernal, scruffian, madhudollu, mikachan, zieladam, bph, poena, andraganescu, ndiego, bgardner. See #56467. git-svn-id: https://develop.svn.wordpress.org/trunk@54105 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-includes/class-wp-theme-json.php | 25 +++++++++++++++++-------- 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/src/wp-includes/class-wp-theme-json.php b/src/wp-includes/class-wp-theme-json.php index a299c8556ef66..2833e8be9c94d 100644 --- a/src/wp-includes/class-wp-theme-json.php +++ b/src/wp-includes/class-wp-theme-json.php @@ -347,16 +347,22 @@ class WP_Theme_JSON { * The valid elements that can be found under styles. * * @since 5.8.0 + * @since 6.1.0 Added `heading`, `button`, and `caption` to the elements. * @var string[] */ const ELEMENTS = array( - 'link' => 'a', - 'h1' => 'h1', - 'h2' => 'h2', - 'h3' => 'h3', - 'h4' => 'h4', - 'h5' => 'h5', - 'h6' => 'h6', + 'link' => 'a', + 'heading' => 'h1, h2, h3, h4, h5, h6', + 'h1' => 'h1', + 'h2' => 'h2', + 'h3' => 'h3', + 'h4' => 'h4', + 'h5' => 'h5', + 'h6' => 'h6', + // We have the .wp-block-button__link class so that this will target older buttons that have been serialized. + 'button' => '.wp-element-button, .wp-block-button__link', + // The block classes are necessary to target older content that won't use the new class names. + 'caption' => '.wp-element-caption, .wp-block-audio figcaption, .wp-block-embed figcaption, .wp-block-gallery figcaption, .wp-block-image figcaption, .wp-block-table figcaption, .wp-block-video figcaption', ); /** @@ -1476,7 +1482,10 @@ protected static function get_style_nodes( $theme_json, $selectors = array() ) { ); if ( isset( $theme_json['styles']['elements'] ) ) { - foreach ( $theme_json['styles']['elements'] as $element => $node ) { + foreach ( self::ELEMENTS as $element => $selector ) { + if ( ! isset( $theme_json['styles']['elements'][ $element ] ) ) { + continue; + } $nodes[] = array( 'path' => array( 'styles', 'elements', $element ), 'selector' => static::ELEMENTS[ $element ],