-
Notifications
You must be signed in to change notification settings - Fork 934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update React Native snapshot #573
Update React Native snapshot #573
Conversation
- update snapshots
5135b93
to
c4c3800
Compare
@@ -19,7 +19,6 @@ exports[`renders with React Native components 1`] = ` | |||
onBlur={[Function]} | |||
onChange={[Function]} | |||
onChangeText={[Function]} | |||
onKeyDown={[Function]} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we not need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope!
See #451 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This lists the valid props for RN Text Input - no onKeyDown: https://facebook.github.io/react-native/docs/0.56/view#props
🎉 This PR is included in version 2.2.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
- update snapshots
See: #451
Also re-add
onChange
. Question - should there be something in the README about the RN only tests? Is there? Did I miss it?