Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update React Native snapshot #573

Merged
merged 1 commit into from
Sep 6, 2018

Conversation

samuelfullerthomas
Copy link
Contributor

@samuelfullerthomas samuelfullerthomas commented Sep 5, 2018

See: #451

Also re-add onChange. Question - should there be something in the README about the RN only tests? Is there? Did I miss it?

@samuelfullerthomas samuelfullerthomas changed the title Check for rn Update React Native snapshot Sep 5, 2018
@samuelfullerthomas
Copy link
Contributor Author

@kentcdodds

@@ -19,7 +19,6 @@ exports[`renders with React Native components 1`] = `
onBlur={[Function]}
onChange={[Function]}
onChangeText={[Function]}
onKeyDown={[Function]}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not need this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope!

See #451 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lists the valid props for RN Text Input - no onKeyDown: https://facebook.github.io/react-native/docs/0.56/view#props

@kentcdodds kentcdodds merged commit 444e76e into downshift-js:master Sep 6, 2018
@kentcdodds
Copy link
Member

🎉 This PR is included in version 2.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants