Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): add disabled attribute to blocks drawer toggler #9424

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

rilrom
Copy link
Contributor

@rilrom rilrom commented Nov 22, 2024

What?

When update access control is set to false, the blocks drawer can still be accessed. Blocks still cannot be saved to the document, making this more of a QoL improvement.

Why?

The blocks DrawerToggler is missing the disabled attribute.

How?

Adding the disabled attribute to the blocks DrawerToggler.

Reproduction steps

https://github.com/rilrom/payload/tree/issue/disabled-add-block-button

  1. Navigate to the posts collection.
  2. Click the 'Add blocks' button.
  3. Blocks can be selected (however they are still readonly in the document and cannot be saved).

Recordings

Before

before.mp4

After

after.mp4

Copy link
Member

@AlessioGr AlessioGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@AlessioGr AlessioGr merged commit 27acdae into payloadcms:main Nov 22, 2024
56 of 57 checks passed
Copy link
Contributor

🚀 This is included in version v3.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants